-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 362] Improve Performance constructing the asofJoin()
#363
Conversation
…join on very large DFs (large number of columns)
…_getLastRightRow all test-code passing
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 87.72% 87.67% -0.06%
==========================================
Files 6 6
Lines 872 876 +4
Branches 177 182 +5
==========================================
+ Hits 765 768 +3
Misses 81 81
- Partials 26 27 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a few changes that make the code simpler. I'd like to move away from lambda
unless it's actually needed
Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT but suggested adding TODO
on the comment regarding batch renaming so we can find it again easily.
Approving though. Thanks for the updates
Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com>
asofJoin()
Fix for #362 - improving performance of constructing the
asofJoin(...)
function.