Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 362] Improve Performance constructing the asofJoin() #363

Merged
merged 16 commits into from
Sep 22, 2023
Merged

Conversation

tnixon
Copy link
Contributor

@tnixon tnixon commented Sep 21, 2023

Fix for #362 - improving performance of constructing the asofJoin(...) function.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #363 (8cd949f) into master (9f2bbe4) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 8cd949f differs from pull request most recent head 78fc76e. Consider uploading reports for the commit 78fc76e to get more accurate results

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   87.72%   87.67%   -0.06%     
==========================================
  Files           6        6              
  Lines         872      876       +4     
  Branches      177      182       +5     
==========================================
+ Hits          765      768       +3     
  Misses         81       81              
- Partials       26       27       +1     
Files Changed Coverage Δ
python/tempo/tsdf.py 86.32% <100.00%> (-0.11%) ⬇️

Copy link
Contributor

@rportilla-databricks rportilla-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@R7L208 R7L208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few changes that make the code simpler. I'd like to move away from lambda unless it's actually needed

tnixon and others added 2 commits September 22, 2023 09:27
Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com>
@tnixon tnixon requested a review from R7L208 September 22, 2023 16:32
Copy link
Contributor

@R7L208 R7L208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT but suggested adding TODO on the comment regarding batch renaming so we can find it again easily.

Approving though. Thanks for the updates

tnixon and others added 3 commits September 22, 2023 09:58
Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com>
@R7L208 R7L208 changed the title Issue 362 [Issue 362] Improve Performance constructing the asofJoin() Sep 22, 2023
@tnixon tnixon merged commit b531dac into master Sep 22, 2023
@tnixon tnixon deleted the issue_362 branch September 22, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants