Update AS OF join to avoid get plan bytes logic #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 85.65% 85.02% -0.64%
==========================================
Files 6 6
Lines 767 768 +1
Branches 159 160 +1
==========================================
- Hits 657 653 -4
- Misses 92 97 +5
Partials 18 18 |
|
@rportilla-databricks I made a few small tweaks to the code here. Please take a look |
tnixon
added a commit
that referenced
this pull request
Jun 6, 2023
tnixon
added a commit
that referenced
this pull request
Jun 7, 2023
* standardizing package imports * black reformatting * simplify the TSDF imports * reorganize imports * Revert "simplify the TSDF imports" This reverts commit 0cefd1569f110c4e7f27db23bfa33db3a1bc730e. * refactoring sql_fn to sfn based on popular demand * Describe module import standards * black formatting * restoring dlt asofjoin fix from #334 * Update python/tests/intervals_tests.py hmmm - guess I missed this one :D Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com> * Update python/tests/intervals_tests.py good catch Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com> * Update python/tests/intervals_tests.py Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com> * Update python/tests/intervals_tests.py Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com> --------- Co-authored-by: Lorin Dawson <22798188+R7L208@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AS OF join logic to remove the plan logic to function within DLT