Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy, coverage] Complete Type Checking for the Project and updates to Coverage configuration #324

Merged
merged 108 commits into from
May 31, 2023
Merged

[mypy, coverage] Complete Type Checking for the Project and updates to Coverage configuration #324

merged 108 commits into from
May 31, 2023

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Apr 28, 2023 •
edited
Loading

This PR includes:

  • changes required to pass type checks for mypy
  • updated GH workflow test.yml to enforce type checking moving forward on push and pull_request
  • new unit tests to compensate for the drop in coverage, hitting 87% coverage now
  • update tox and GH Actions to use coverage combine to produce a .coverage file when running in parallel-mode

Lorin Dawson and others added 30 commits April 19, 2023 15:32
update gitignore for pyenv files
b6ad62c
ignore tox files
56c18a2
hardcode version instead of pulling from gh
e0f42e6 
importing semver in setup caused an error bc it was being imported before requirements file could install it
move coverage requirement to tox config
c254c24
remove version py file since it's hardcoded in setup
c41d140
initial working tox commit
15b7d1f
update required coverage versions to be more flexible
a3b0101
switch order formatters run
4e899f5
ignore env specific coverage files
dee6106
update tox config to use coverage run instead of base python to execu…
7e977ed 
…te tests
add coverage report env to tox config
5955700
update coverage-report description
66f488e
update a env name for type checking
10d4394
remove black and flake8 from requirments package and into tox envs
c7b2e0c
update contributing md file with tox instructions
59bc245
add pyenv and tox instructions to CONTRIBUTING md
bbc0406
Merge branch 'master' into tox-support
7aa9817
@R7L208
Update test.yml
1ab4bd0
adding comment to force testing on GH actions
92d4836
removing comment to force testing on GH actions
0d658e9
@R7L208
Update test.yml to fix error caused by typo
fae1671
Revert "remove version py file since it's hardcoded in setup"
571746b 
This reverts commit c41d140.
Revert "hardcode version instead of pulling from gh"
2a0b2fb 
This reverts commit e0f42e6.
add semver as a dep for testenv in tox ini
6004da3
Merge remote-tracking branch 'origin/tox-support' into tox-support
a4d6629
add pyproject toml to install semver as build requirement
6093075
update type default env to type-check
b4a170a 
this matches the actual env name since type was renamed to type-check
fix merge conflict
6599a32
move all flake8 configs to tox.ini file
1d30f56 
flake8 was returning different results locally in virtual env and using tox. This is because the configuration in tox.ini takes precedence over the .flake8 config file. In addition, flake8 no longer supports a global config file after version 4
remove toxinidir from flake8 command
681c97c
Lorin Dawson added 24 commits May 1, 2023 09:54
add seconds to typed freq dict
e074fcc
add minutes to typed freq dict
89fd5ae
add second to freq dict and force unit to lowercase before checking
2df6af1
add additional valid frequences to typed freq dict
68c796d
update checkAllowableFreq function to pass type checks
054539d
add test to check raise when invalid freq is passed to _appendAggKey
a6c12b5
remove unneded check because valid freq is handled in checkAllowableF…
cd6915c 
…req now
remove another unneeded check since checking for valid freq values is…
2463d07 
… fully handled by checkAllowableFreq
fixes for type checking
205cfb8
remove unreachable pass after return statement
637e2f1
add ... as exclusion for non implemented methods
1c3fb9c
update typing because partition cols is optional for TSDF
9da4460
new unit tests for tsdf
8922f59
remove unneded check since literals are handled by checkAllowableFreq
af6085c
formatting
5abc8bb
formatting
71db32e
new unit tests for tsdf
8236a44
fix coverage report error
0ac8bd5 
parallel mode uses system info to not conflict with other reports
see if parallel mode works again if codecov combine is used
bb9e2cd
the updated GH workflow for previous commit
1efbd12
move coveragerc file to top dir so it's discoverable by IDEs
a4ca9b3
Revert "move coveragerc file to top dir so it's discoverable by IDEs"
b50fbf9 
This reverts commit a4ca9b3.
move coveragerc file to project root
eac55e5
Revert "move coveragerc file to project root"
2fafc46 
This reverts commit eac55e5.
@R7L208 R7L208 changed the title [mypy, coverage] Complete Type Checking for the Project and Exclude test files from Coverage Report [mypy, coverage] Complete Type Checking for the Project and updates to Coverage configuration May 2, 2023
tnixon
tnixon approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnixon tnixon merged commit cabe0c4 into master May 31, 2023
@tnixon tnixon deleted the pass-mypy-checks branch May 31, 2023 22:31
@tnixon tnixon mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnixon tnixon tnixon approved these changes

@rportilla-databricks rportilla-databricks Awaiting requested review from rportilla-databricks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R7L208 @tnixon