Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to mark source directory as "safe" for git to perform actions during docs build #314

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

tnixon
Copy link
Contributor

@tnixon tnixon commented Apr 17, 2023

We have a system call to git during the docs build that fetches the current release version from git tags. This started to fail because the directory where the code was cloned was not marked as "safe". This should fix that issue.

@tnixon tnixon requested a review from R7L208 April 17, 2023 18:06
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #314 (a7d5da9) into master (8270aa6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files           6        6           
  Lines         767      767           
  Branches      159      159           
=======================================
  Hits          657      657           
  Misses         92       92           
  Partials       18       18           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@R7L208 R7L208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tnixon

@tnixon tnixon merged commit 307e5f8 into master Apr 17, 2023
@tnixon tnixon deleted the fix_docs_build branch April 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants