Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed old deprecated scala code #308

Merged
merged 3 commits into from
Apr 14, 2023
Merged

removed old deprecated scala code #308

merged 3 commits into from
Apr 14, 2023

Conversation

tnixon
Copy link
Contributor

@tnixon tnixon commented Apr 14, 2023

This closes #306

@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Merging #308 (ac7f1f5) into master (e82c213) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files           6        6           
  Lines         757      757           
  Branches      156      156           
=======================================
  Hits          647      647           
  Misses         92       92           
  Partials       18       18

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

R7L208
R7L208 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@R7L208 R7L208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

souvik-databricks
souvik-databricks reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@souvik-databricks souvik-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks okay to me.

Just one thing. I think we need to add a line in the sphinx documentation mentioning that the scala package is no longer supported going forward.

rportilla-databricks
rportilla-databricks approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@rportilla-databricks rportilla-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want at banner on the top-level README (

souvik-databricks
souvik-databricks approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@souvik-databricks souvik-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@souvik-databricks souvik-databricks merged commit 7ddcdfa into master Apr 14, 2023
@tnixon tnixon deleted the goodbye_scala branch April 14, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R7L208 R7L208 R7L208 approved these changes

@rportilla-databricks rportilla-databricks rportilla-databricks approved these changes

@souvik-databricks souvik-databricks souvik-databricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate & remove Scala code
4 participants
@tnixon @R7L208 @rportilla-databricks @souvik-databricks