Add tolerance parameter to asofJoin #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nina-hu - I see that you've added a parameter to several methods, are you going to provide an implementation, too? |
added 3 commits
April 7, 2023 10:32
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 85.46% 85.65% +0.18%
==========================================
Files 6 6
Lines 757 767 +10
Branches 156 159 +3
==========================================
+ Hits 647 657 +10
Misses 92 92
Partials 18 18 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tnixon
suggested changes
Apr 12, 2023
AveshCSingh
reviewed
Apr 12, 2023
this can be done with the command: |
tnixon
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tolerance parameter to as_of_join() in tempo. When this parameter is set, the as_of_join will only pull in rows from the right df that are within the tolerance band. If no such values exist in the right df, then null values will be returned.
Design details: https://docs.google.com/document/d/1EoFqCf_sXgANnRNXnAn88FzbrEN5UJOFYlCk7l02dyg/edit#heading=h.bsuf6cksdce9