Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unit tests to chispa and increase test coverage #240

Merged
merged 62 commits into from
Sep 1, 2022
Merged

Migrate unit tests to chispa and increase test coverage #240

merged 62 commits into from
Sep 1, 2022

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Aug 10, 2022 •
edited
Loading

fixes #233

  • migrate unit tests for dataframe equality to chispa

    • removed methods for schema equality checks since this is performed as part of assert_df_equality
    • combined assertDataFramesEqual and assertTSDFsEqual into a single static method
    • renamed arguments dfA1 and dfB to reflect df1 and df2 in chispas comparison output

  • add .coveragerc file

  • Improve coverage for code base

@codecov
Copy link

codecov bot commented Aug 10, 2022 •
edited
Loading

Codecov Report

Merging #240 (3c678b6) into master (a51f1bf) will decrease coverage by 3.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   86.88%   83.15%   -3.73%     
==========================================
  Files          12        5       -7     
  Lines        1273      653     -620     
  Branches        0      143     +143     
==========================================
- Hits         1106      543     -563     
+ Misses        167       92      -75     
- Partials        0       18      +18
Impacted Files Coverage Δ
tests/delta_writer_tests.py
tests/utils_tests.py
tests/base.py
tests/interpol_tests.py
tempo/__init__.py
tests/tsdf_tests.py
tests/as_of_join_tests.py
tempo/tsdf.py 77.25% <0.00%> (+1.43%) ⬆️
tempo/interpol.py 100.00% <0.00%> (+2.27%) ⬆️
tempo/utils.py 62.74% <0.00%> (+4.93%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@R7L208 R7L208 changed the title Migrate unit tests to chispa [DRAFT] Migrate unit tests to chispa Aug 10, 2022
@R7L208 R7L208 marked this pull request as draft August 10, 2022 23:41
@R7L208 R7L208 marked this pull request as ready for review August 15, 2022 15:17
@R7L208 R7L208 requested a review from tnixon August 15, 2022 15:17
@R7L208 R7L208 mentioned this pull request Aug 15, 2022
Closed
@R7L208 R7L208 changed the title [DRAFT] Migrate unit tests to chispa Migrate unit tests to chispa Aug 15, 2022
@R7L208 R7L208 mentioned this pull request Aug 15, 2022
Closed
@R7L208 R7L208 changed the title Migrate unit tests to chispa Migrate unit tests to chispa and increase test coverage Aug 15, 2022
tnixon and others added 27 commits August 16, 2022 18:12
@tnixon
Need to set timezone to UTC in spark for test code to make sure timez…
23db818 
…ones are parsed consistently regardless of location where run

(by default spark uses machine's configured TZ)
@tnixon
Merge branch 'issue233-migrate-unit-tests-to-chispa' of https://githu…
94f6772 
…b.com/databrickslabs/tempo into issue233-migrate-unit-tests-to-chispa
@tnixon
Need to set timezone to UTC in spark for test code to make sure timez…
7d46ec5 
…ones are parsed consistently regardless of location where run

(by default spark uses machine's configured TZ)
also fixed several test cases
@R7L208
final updates for resample
e644339
@R7L208
rename delta_writer_tests and unit test data file to reflect name of io
66173c8
@R7L208
get rid of circular reference w/o using typing.TYPE_CHECKING
99cc76f
@R7L208
timezone config to fix resample tests
b71a373
@R7L208
removing final prints and shows)
4aec025
@R7L208
up coverage for io file
befc82b
@R7L208
rename io tests to better reflect test case
51206cf
@R7L208
flake8
b079fb4
@R7L208
working changes for temporal slicing tests in tsdf_tests
74b8356
@R7L208
black formatting
dde5f43
@R7L208
add mock for UTC timezone for __timestamp_to_double
af7a1e0
@R7L208
add UTC mock to utils_tests test_calcuulate_time_horizon
c0caf47
@R7L208
99 to 100 coverage in resample
1fa7a27
@R7L208
update gitignore for coverage file
805aeaa
@R7L208
remove coveragerc file
bd1f860
@R7L208
Revert "remove coveragerc file"
bb69b20 
This reverts commit bd1f860.
@R7L208
Revert "update gitignore for coverage file"
47fcd4b 
This reverts commit 805aeaa.
@R7L208
new test for interpol to hit 100 branch coverage
2829c46
@R7L208
black
1104c7f
@R7L208
formatting changes and make __validate_ts_string static
6596a54
@R7L208
working changes for tsdf test cases
32d3d91
@R7L208
coverage for tsdf to 82 perscent
36a4a40
@R7L208
black & flake8 formatting
498c20e
@R7L208
updates to utils for coverage
3c678b6
tnixon
tnixon approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent and very helpful

@tnixon tnixon merged commit 0350dff into master Sep 1, 2022
@tnixon tnixon deleted the issue233-migrate-unit-tests-to-chispa branch September 1, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnixon tnixon tnixon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate unit tests to use Chispa
2 participants
@R7L208 @tnixon