Update TSDF.extractStateInterval() to perform state comparison per metric column.
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix for issue 232 * allowing function of (Column, Column) -> Column as alternate state_definition arg * returning basic DF, not TSDF
fix bug when extracting non-TSDF compatible test dataframes
…tervals into special format
…tabrickslabs/tempo into bugfix_extractStateIntervals_issue232
test cases need to be updated to allow 5 return columns instead of 4
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 86.11% 86.88% +0.76%
==========================================
Files 12 12
Lines 1210 1273 +63
==========================================
+ Hits 1042 1106 +64
+ Misses 168 167 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rportilla-databricks
approved these changes
Jul 26, 2022
tnixon
reviewed
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #232
Changes in this PR:
For method
TSDF.extractStateInterval()intsdf.py:Update
TSDF.extractStateInterval()to perform state comparison per metric columnUnified approach for metric comparison for
state_defninitionof typestrandCallableFixed type signature of
TSDF.extractStateInterval()Cleaned up comments in
TSDF.extractStateinterval()and selected less ambiguous var name forstate_comp_fnFor class
ExtractStateIntervalsTest: