Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added downstreams action #141

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Added downstreams action #141

merged 1 commit into from
Mar 30, 2024

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Mar 30, 2024

Comments on PR whenever backwards compatibility is broken:

image

And fails the build:

image

Usage:

name: downstreams

on:
  pull_request:
    types: [opened, synchronize]
  merge_group:
    types: [checks_requested]
  push:
    # Always run on push to main. The build cache can only be reused
    # if it was saved by a run from the repository's default branch.
    # The run result will be identical to that from the merge queue
    # because the commit is identical, yet we need to perform it to
    # seed the build cache.
    branches:
      - main

permissions:
  id-token: write
  contents: read
  pull-requests: write

jobs:
  compatibility:
    strategy:
      fail-fast: false
      matrix:
        downstream:
          - name: ucx
            org: databrickslabs
          - name: blueprint
            org: databrickslabs
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3
        with:
          fetch-depth: 0

      - name: Install Python
        uses: actions/setup-python@v4
        with:
          python-version: '3.10'

      - name: Install toolchain
        run: |
          pip install hatch==1.9.4
      - name: Acceptance
        uses: databrickslabs/sandbox/downstreams@downstreams/v0.0.1
        with:
          repo: ${{ matrix.downstream.name }}
          org: ${{ matrix.downstream.org }}
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@nfx nfx requested a review from a team as a code owner March 30, 2024 13:57
@nfx nfx requested a review from esiol-db March 30, 2024 13:57
@nfx nfx merged commit 4424e7e into main Mar 30, 2024
5 of 7 checks passed
@nfx nfx deleted the downstreams branch March 30, 2024 13:58
nfx added a commit to databrickslabs/blueprint that referenced this pull request Mar 30, 2024
nfx added a commit to databrickslabs/lsql that referenced this pull request Mar 30, 2024
Automate downstream unit testing. See databrickslabs/sandbox#141 for more details.
nfx added a commit to databrickslabs/lsql that referenced this pull request Mar 30, 2024
Automate downstream unit testing. See
databrickslabs/sandbox#141 for more details.
github-merge-queue bot pushed a commit to databricks/databricks-sdk-py that referenced this pull request Apr 5, 2024
## Changes
Comments on PR whenever downstream fails to compile or fails unit tests.
See implementation for more details:
- databrickslabs/sandbox#141

Backwards incompatible changes would result in comments similar to:
<img width="832" alt="image"
src="https://github.com/databricks/databricks-sdk-py/assets/259697/b1554491-6a80-417b-a2be-1350fa09b424">

Current downstream checking graph:

```mermaid
graph TD

pysdk[Python SDK: ***this PR***] --> ucx
pysdk --> blueprint

blueprint --> lsql
blueprint --> ucx
blueprint --> remorph

lsql --> ucx
lsql --> remorph
```


## Tests

Manual

---------

Signed-off-by: Serge Smertin <259697+nfx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant