Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain PySpark compatibility for databricks.labs.lsql.core.Row #99

Merged
merged 2 commits into from
May 8, 2024
Merged

Maintain PySpark compatibility for databricks.labs.lsql.core.Row #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
801770a
Add asDict to databricks.labs.lsql.core.Row to maintain PySpark compa…
bishwajit-db May 6, 2024
f94206b
Add asDict to databricks.labs.lsql.core.Row to maintain PySpark compa…
bishwajit-db May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/databricks/labs/lsql/backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ def fetch(self, sql: str, *, catalog: str | None = None, schema: str | None = No
self._spark.sql(f"USE CATALOG {catalog}")
if schema:
self._spark.sql(f"USE SCHEMA {schema}")
# TODO: pyspark.sql.Row is being returned instead of databricks.labs.lsql.core.Row
return iter(self._spark.sql(sql).collect())
except Exception as e:
error_message = str(e)
Expand Down
4 changes: 4 additions & 0 deletions src/databricks/labs/lsql/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ def as_dict(self) -> dict[str, Any]:
"""Convert the row to a dictionary with the same conventions as Databricks SDK."""
return dict(zip(self.__columns__, self, strict=True))

# PySpark's compatibility
def asDict(self, recursive: bool = False) -> dict[str, Any]:
return self.as_dict()

def __eq__(self, other):
"""Check if the rows are equal."""
if not isinstance(other, Row):
Expand Down
Loading