Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] save_to_folder does not persist markdown tiles #229

Closed
JCZuurmond opened this issue Jul 19, 2024 · 0 comments · Fixed by #230
Closed

[BUG] save_to_folder does not persist markdown tiles #229

JCZuurmond opened this issue Jul 19, 2024 · 0 comments · Fixed by #230

Comments

@JCZuurmond
Copy link
Member

No description provided.

@nfx nfx closed this as completed in #230 Jul 22, 2024
@nfx nfx closed this as completed in 05451a9 Jul 22, 2024
nfx added a commit that referenced this issue Jul 22, 2024
* Fixed dashboard deployment/creation ([#230](#230)). The recent changes to our open-source library address issues related to dashboard deployment and creation, enhancing their reliability and consistency. The `deploy_dashboard` function has been deprecated in favor of the more accurate `create_dashboard` function, which now includes a `publish` flag. A `validate` method has been added to the `Tile`, `MarkdownTile`, and `QueryTile` classes to raise an error if the dashboard is invalid. The `test_dashboards.py` file has been updated to reflect these changes. These enhancements address issues [#222](#222), [#229](#229), and partially resolve [#220](#220). The commit includes an image of a dashboard created through the deprecated `deploy_dashboard` method. These improvements ensure better dashboard creation, validation, and deployment, while also maintaining backward compatibility through the deprecation of `deploy_dashboard`.
@nfx nfx mentioned this issue Jul 22, 2024
nfx added a commit that referenced this issue Jul 22, 2024
* Fixed dashboard deployment/creation
([#230](#230)). The recent
changes to our open-source library address issues related to dashboard
deployment and creation, enhancing their reliability and consistency.
The `deploy_dashboard` function has been deprecated in favor of the more
accurate `create_dashboard` function, which now includes a `publish`
flag. A `validate` method has been added to the `Tile`, `MarkdownTile`,
and `QueryTile` classes to raise an error if the dashboard is invalid.
The `test_dashboards.py` file has been updated to reflect these changes.
These enhancements address issues
[#222](#222),
[#229](#229), and partially
resolve [#220](#220). The
commit includes an image of a dashboard created through the deprecated
`deploy_dashboard` method. These improvements ensure better dashboard
creation, validation, and deployment, while also maintaining backward
compatibility through the deprecation of `deploy_dashboard`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant