-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle functools.partial parameters in error messages #91
Closed
grusin-db
wants to merge
4
commits into
databrickslabs:main
from
grusin-db:handle_partial_parameters
Closed
handle functools.partial parameters in error messages #91
grusin-db
wants to merge
4
commits into
databrickslabs:main
from
grusin-db:handle_partial_parameters
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
Apr 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 78.45% 78.54% +0.08%
==========================================
Files 14 14
Lines 1453 1468 +15
Branches 257 261 +4
==========================================
+ Hits 1140 1153 +13
- Misses 226 228 +2
Partials 87 87 ☔ View full report in Codecov by Sentry. |
nfx
requested changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When partial methods are used, the error messages don't give any information which function invocation cased a problem.
This PR resolves it by adding optional info (args and/or kwargs) in the error message. Existing non-partial function error messages are not changed in any way.
black
dependency was added, otherwisemake lint
was erroring out for me. (make dev
did not pull it in for some reason)I have ran
make fmt
,make lint
,make test
. All green!