[SC-138006] Fix datagen install issue after gcc upgrade to 11+ #7
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
pushed a commit
to apache/spark
that referenced
this pull request
Feb 19, 2025
…mark` from 20.04 to latest ### What changes were proposed in this pull request? This PR aims to upgrade Github Action image for `TPCDSQueryBenchmark` from 20.04 to latest and update the dependency of `databricks/tpcds-kit` to the latest codes. In the past, there were compilation problems in high-version Ubuntu images due to g++ version compatibility issues, but this problem has been solved after this PR: databricks/tpcds-kit#7 ### Why are the changes needed? Refer to: actions/runner-images#11101 > The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-01  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual check on Ubuntu 24.04 and Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49980 from wayneguow/tpcds_inf. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
LuciferYang
pushed a commit
to apache/spark
that referenced
this pull request
Feb 19, 2025
…mark` from 20.04 to latest ### What changes were proposed in this pull request? This PR aims to upgrade Github Action image for `TPCDSQueryBenchmark` from 20.04 to latest and update the dependency of `databricks/tpcds-kit` to the latest codes. In the past, there were compilation problems in high-version Ubuntu images due to g++ version compatibility issues, but this problem has been solved after this PR: databricks/tpcds-kit#7 ### Why are the changes needed? Refer to: actions/runner-images#11101 > The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-01  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual check on Ubuntu 24.04 and Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49980 from wayneguow/tpcds_inf. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: yangjie01 <yangjie01@baidu.com> (cherry picked from commit 0af25b8) Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tpcds lib hit a build issue in dbr 13+. Example error:
The failure is due to the GCC was updated from 9.4.0 to 11.3.0 in DBR.According to the gcc doc link,
If the header is included by several files it results in multiple definitions of the same variable. In previous GCC versions this error is ignored. GCC 10 defaults to -fno-common, which means a linker error will now be reported.To mitigate the issue, need to add flag-fcommonto the CFLAGS in the make file.Tested on devbox with gcc-11 with command
make CC=gcc-11 -f Makefile.suite