Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency] Bump Databricks Go SDK to v0.56.1 #4430

Merged
merged 7 commits into from
Jan 24, 2025
Merged

[Dependency] Bump Databricks Go SDK to v0.56.1 #4430

merged 7 commits into from
Jan 24, 2025
+2,252 −522

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Jan 23, 2025 •
edited
Loading

Changes

v0.56.1 includes changes to support the Apps resource, specifically for APIs that require both query parameters and a request body simultaneously.

Two significant bugfixes:

  1. Model serving endpoint's config was made optional in the latest API spec. However, I don't think there is a way to remove a config from an endpoint. Following up with the team. In the meantime, removing a config will just cause us to call the update config endpoint with an empty body.
  2. Custom Auth Integrations scopes can now be updated. I've removed the ForceNew annotation.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@mgyucht mgyucht requested review from a team as code owners January 23, 2025 08:58
@mgyucht mgyucht requested review from parthban-db and removed request for a team January 23, 2025 08:58
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 08:58 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 09:42 — with GitHub Actions Inactive
@mgyucht mgyucht mentioned this pull request Jan 23, 2025
Merged
github-merge-queue bot pushed a commit to databricks/databricks-sdk-go that referenced this pull request Jan 23, 2025
@mgyucht
[Fix] Do not send query parameters when set to zero value (#1136)
18cebf1 
## What changes are proposed in this pull request?

#1124 fixed the handling of APIs that use query parameters and a body
simultaneously. After that change, query parameters are always sent,
even if set to the zero value.

This PR addresses this, using the same logic for query parameters as for
fields in the body: if a field is set to its zero value, it will be
included in the query parameter if it is present in ForceSendFields.

## How is this tested?

This behavior is dependend upon in the Terraform provider. I'll be using
it in
databricks/terraform-provider-databricks#4430
and verifying that there is no behavior change in the generated request.

When using this PR in Terraform, tests asserting that the path doesn't
include query parameters pass.
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 12:23 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 12:25 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 14:04 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 14:04 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 14:04 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 23, 2025 14:11 — with GitHub Actions Inactive
@mgyucht mgyucht changed the title [Dependency] Bump Databricks Go SDK to v0.56.0 [Dependency] Bump Databricks Go SDK to v0.56.1 Jan 23, 2025
@mgyucht mgyucht enabled auto-merge January 23, 2025 15:06
@mgyucht mgyucht temporarily deployed to test-trigger-is January 24, 2025 09:07 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 24, 2025 09:07 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 24, 2025 09:27 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 24, 2025 09:27 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4430
  • Commit SHA: b974dc1f2e40dd3ab4a9bec55aea49791e825703

Checks will be approved automatically on success.

@mgyucht mgyucht mentioned this pull request Jan 24, 2025
Closed
5 tasks
@mgyucht mgyucht added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit c11b883 Jan 24, 2025
12 checks passed
@mgyucht mgyucht deleted the bump-go-sdk-v0.56 branch January 24, 2025 10:31
mgyucht added a commit that referenced this pull request Jan 27, 2025
@mgyucht
[Release] Release v1.64.0
1e19f16 
### New Features and Improvements

 * Add `no_compute` attribute to `databricks_app` ([#4364](#4364)).
 * Skip calling Read after Create/Update operations for `databricks_notebook` ([#4173](#4173)).

### Bug Fixes

 * Recreate `databricks_token` if it's not found or expired ([#4431](#4431)).
 * Handle empty response properly in `databricks_mws_workspaces` data source ([#4414](#4414)).
 * Recreate `databricks_obo_token` if it's removed or expired ([#4428](#4428)).

### Documentation

 * Added Queue Data Contributor role to Azure terraform docs ([#4412](#4412)).
 * Replaced references to data security mode with access mode ([#4408](#4408)).

### Internal Changes

 * Account for historical release headers when filtering on past changelog sections ([#4409](#4409)).
 * Introduce automated tagging ([#4366](#4366)).
 * Remove .extraheader config ([#4405](#4405)).
 * Remove tag signing in tagging.py script ([#4407](#4407)).
 * Set runs-on to use our internal runners ([#4403](#4403)).

### Dependency Updates

 * Bump Databricks Go SDK to v0.56.1 ([#4430](#4430)).
 * Bump github.com/hashicorp/terraform-plugin-go from 0.25.0 to 0.26.0 ([#4429](#4429)).
 * Bump github.com/hashicorp/terraform-plugin-mux from 0.17.0 to 0.18.0 ([#4432](#4432)).
 * Bump github.com/zclconf/go-cty from 1.16.1 to 1.16.2 ([#4423](#4423)).

### Exporter

 * **Breaking**: rename `workspace` service into `wsconf` ([#4425](#4425)).
 * Add listing for `databricks_permissions` so we can emit permissions for tokens ([#4402](#4402)).
 * Refactor jobs implementation to use only Go SDK ([#4380](#4380)).
 * improve handling of Emit/Add operations under the heavy load ([#4401](#4401)).
@mgyucht mgyucht mentioned this pull request Jan 27, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 27, 2025
@mgyucht
[Release] Release v1.64.0 (#4435)
897ca95 
### New Features and Improvements

* Add `no_compute` attribute to `databricks_app`
([#4364](#4364)).
* Skip calling Read after Create/Update operations for
`databricks_notebook`
([#4173](#4173)).


### Bug Fixes

* Recreate `databricks_token` if it's not found or expired
([#4431](#4431)).
* Handle empty response properly in `databricks_mws_workspaces` data
source
([#4414](#4414)).
* Recreate `databricks_obo_token` if it's removed or expired
([#4428](#4428)).


### Documentation

* Added Queue Data Contributor role to Azure terraform docs
([#4412](#4412)).
* Replaced references to data security mode with access mode
([#4408](#4408)).


### Internal Changes

* Account for historical release headers when filtering on past
changelog sections
([#4409](#4409)).
* Introduce automated tagging
([#4366](#4366)).
* Remove .extraheader config
([#4405](#4405)).
* Remove tag signing in tagging.py script
([#4407](#4407)).
* Set runs-on to use our internal runners
([#4403](#4403)).


### Dependency Updates

* Bump Databricks Go SDK to v0.56.1
([#4430](#4430)).
* Bump github.com/hashicorp/terraform-plugin-go from 0.25.0 to 0.26.0
([#4429](#4429)).
* Bump github.com/hashicorp/terraform-plugin-mux from 0.17.0 to 0.18.0
([#4432](#4432)).
* Bump github.com/zclconf/go-cty from 1.16.1 to 1.16.2
([#4423](#4423)).


### Exporter

* **Breaking**: rename `workspace` service into `wsconf`
([#4425](#4425)).
* Add listing for `databricks_permissions` so we can emit permissions
for tokens
([#4402](#4402)).
* Refactor jobs implementation to use only Go SDK
([#4380](#4380)).
* improve handling of Emit/Add operations under the heavy load
([#4401](#4401)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@rauchy rauchy rauchy approved these changes

@hectorcast-db hectorcast-db hectorcast-db approved these changes

@parthban-db parthban-db Awaiting requested review from parthban-db parthban-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgyucht @alexott @rauchy @hectorcast-db