Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't silently swallow unclosed tag content; propagate for error handling instead #437

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

srowen
Copy link
Collaborator

@srowen srowen commented Feb 13, 2020

See #436 (comment) for context. This stops silently swallowing unclosed tags at the end of input and instead propagates the remaining content for normal error handling.

Closes #436

@srowen srowen added this to the 0.9.0 milestone Feb 13, 2020
@srowen srowen self-assigned this Feb 13, 2020
@srowen
Copy link
Collaborator Author

srowen commented Feb 13, 2020

CC @HyukjinKwon in case you're interested

@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #437 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   88.46%   88.86%   +0.39%     
==========================================
  Files          17       17              
  Lines         806      808       +2     
  Branches       71       75       +4     
==========================================
+ Hits          713      718       +5     
+ Misses         93       90       -3
Impacted Files Coverage Δ
...m/databricks/spark/xml/parsers/StaxXmlParser.scala 97.63% <100%> (+0.03%) ⬆️
...cala/com/databricks/spark/xml/XmlInputFormat.scala 93.28% <100%> (+0.74%) ⬆️
...la/com/databricks/spark/xml/util/InferSchema.scala 89.72% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71f735...b0ad451. Read the comment docs.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @srowen for fixing this.

@HyukjinKwon HyukjinKwon merged commit 701e7d5 into databricks:master Feb 14, 2020
@srowen srowen deleted the Issue436 branch February 29, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error raised if xml has only one failed row
3 participants