Added info logging for response #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
reviewed
Feb 19, 2025
| @@ -345,6 +345,8 @@ def should_retry(self, method: str, status_code: int) -> Tuple[bool, str]: | |||
| if a retry would violate the configured policy. | |||
| """ | |||
|
|
|||
| logger.info(f"Received status code {status_code} for {method} request") | |||
There was a problem hiding this comment.
When we get 4xx or 5xx, do we only get a status code, or do we also get an error message of some sort?
There was a problem hiding this comment.
@benc-db I have updated such that the error messages from the server are printed and not our custom messages
benc-db
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added logging for status code and method details for easy debugging