Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the proxy authentication #354

Merged
merged 1 commit into from
May 23, 2024
Merged

Update the proxy authentication #354

merged 1 commit into from
May 23, 2024

Conversation

amir-haroun
Copy link
Contributor

@amir-haroun amir-haroun commented Feb 15, 2024 •
edited
Loading

This PR solves the proxy auth issue reported in #353.
The idea is to use the proxy_headers argument of the ProxyManager instead of the Proxy-Authorization http header according to the API docs

@amir-haroun
Copy link
Contributor Author

@rcypher-databricks, @arikfr , @yansonggao-db , @andrefurlan-db , @jackyhu-db ,@benc-db
Can anyone take a look to this PR?

@kravets-levko
Copy link
Contributor

@amir-haroun I was testing these changes a lot, and the code seems to work fine. I would like to ask you - can you add some tests for this code? Or maybe you can suggest some ideas on how to avoid regressions in future. Thank you!

@amir-haroun
Copy link
Contributor Author

@kravets-levko,
Not sure what can be added as unit tests here (especially for auth...) but we can verify if the proxies are set using urllib.getproxies().get('http')

@kravets-levko kravets-levko merged commit d63b71b into databricks:main May 23, 2024
@kravets-levko kravets-levko mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kravets-levko kravets-levko kravets-levko approved these changes

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks rcypher-databricks is a code owner

@arikfr arikfr Awaiting requested review from arikfr

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db jackyhu-db is a code owner

@benc-db benc-db Awaiting requested review from benc-db benc-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amir-haroun @kravets-levko