[PECO-1286] Complex types tests #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2023 15:30
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
benc-db
reviewed
Nov 28, 2023
| :param _use_arrow_native_complex_types: `bool`, optional | ||
| Controls whether a complex type field value is returned as a string or as a native Arrow type. Defaults to True. | ||
| When True: | ||
| MAP is returned as List[Tuple[str, Any]] |
There was a problem hiding this comment.
Why is MAP not returned as a Dict[str, any]?
There was a problem hiding this comment.
I had the same thought but this seems to be controlled by pyarrow. Updating to use a dict() is a potential improvement we could implement.
There was a problem hiding this comment.
Unclear if it would be an improvement. If this is the native type, let's leave it be.
benc-db
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds e2e tests for the complex type behaviour of this connector. The test demonstrates that when a user selects a field which contains a complex type value that this type is passed through the result as a List,
ndarray, ordict()depending on the type of the field in the table.This can be disabled with a config when building the connection.
As part of an ongoing effort to improve the "hintability" of this connector in a code editor, I've also extracted
_use_arrow_native_complex_typesfromkwargsand added comments for it.