Fix NULL handling in Arrow result handler #195

kravets-levko · 2023-10-05T13:57:41Z

Fixes #188

Preserve NULL values when processing Arrow result

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

kravets-levko · 2023-10-05T13:58:18Z

lib/result/ArrowResult.ts

+      const value = record[field];
+      result[field] = value === null ? null : convertThriftValue(typeDescriptor, value);


This is basically the same logic as in JsonResult:

databricks-sql-nodejs/lib/result/JsonResult.ts

Lines 60 to 65 in 9eb3807

return columnValue.values.map((value: any, i: number) => {

if (columnValue.nulls && this.isNull(columnValue.nulls, i)) {

return null;

}

return convertThriftValue(typeDescriptor, value);

});

susodapop

LGTM

Fix NULL handling in Arrow result handler

bc933b4

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

kravets-levko requested review from arikfr, superdupershant, yunbodeng-db, susodapop, nithinkdb and andrefurlan-db as code owners October 5, 2023 13:57

kravets-levko temporarily deployed to azure-prod October 5, 2023 13:57 — with GitHub Actions Inactive

kravets-levko commented Oct 5, 2023

View reviewed changes

susodapop approved these changes Oct 5, 2023

View reviewed changes

kravets-levko merged commit 959d320 into main Oct 5, 2023

kravets-levko deleted the arrow-result-null-handling branch October 5, 2023 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix NULL handling in Arrow result handler #195

Fix NULL handling in Arrow result handler #195

kravets-levko commented Oct 5, 2023

kravets-levko Oct 5, 2023

susodapop left a comment

		const value = record[field];
		result[field] = value === null ? null : convertThriftValue(typeDescriptor, value);

	return columnValue.values.map((value: any, i: number) => {
	if (columnValue.nulls && this.isNull(columnValue.nulls, i)) {
	return null;
	}
	return convertThriftValue(typeDescriptor, value);
	});

Fix NULL handling in Arrow result handler #195

Fix NULL handling in Arrow result handler #195

Conversation

kravets-levko commented Oct 5, 2023

kravets-levko Oct 5, 2023

Choose a reason for hiding this comment

susodapop left a comment

Choose a reason for hiding this comment