Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query parameters: implement support for binding NULL parameters #189

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Query parameters: implement support for binding NULL parameters #189

merged 2 commits into from
Sep 30, 2023

Conversation

kravets-levko
Copy link
Contributor

This PR adds support for inferring NULL values passed to DBR as parameters. Both null and undefined could be used as NULL values.

Related to databricks/databricks-sql-python#233

@kravets-levko
Query parameters: implement support for binding NULL parameters
d180564 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 30, 2023 17:45 — with GitHub Actions Inactive
@kravets-levko kravets-levko temporarily deployed to azure-prod September 30, 2023 17:56 — with GitHub Actions Inactive
@databricks databricks deleted a comment from codecov-commenter Sep 30, 2023
@kravets-levko
Handle explicit NULL type
e0da4f5 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko force-pushed the suport-null-query-parameters branch from b2db97a to e0da4f5 Compare September 30, 2023 17:58
@kravets-levko kravets-levko temporarily deployed to azure-prod September 30, 2023 17:59 — with GitHub Actions Inactive
@databricks databricks deleted a comment from codecov-commenter Sep 30, 2023
@databricks databricks deleted a comment from codecov-commenter Sep 30, 2023
susodapop
susodapop reviewed Sep 30, 2023
View reviewed changes
Copy link

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one question about passing named values for these parameters. Ordinal passage is working but I think the current implementation might not work for named params.

lib/DBSQLParameter.ts Show resolved Hide resolved
tests/e2e/query_parameters.test.js Show resolved Hide resolved
@kravets-levko kravets-levko merged commit 0618e90 into main Sep 30, 2023
@kravets-levko kravets-levko deleted the suport-null-query-parameters branch September 30, 2023 20:14
@kravets-levko kravets-levko mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susodapop susodapop susodapop approved these changes

@arikfr arikfr Awaiting requested review from arikfr

@superdupershant superdupershant Awaiting requested review from superdupershant superdupershant is a code owner

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@nithinkdb nithinkdb Awaiting requested review from nithinkdb

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kravets-levko @susodapop