Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fixing http_request open_ai_client mixin #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunishsheth2009
Copy link

@sunishsheth2009 sunishsheth2009 commented Jan 14, 2025

What changes are proposed in this pull request?

  • [Fix] Fixing http_request open_ai_client mixin

How is this tested?

https://dbc-436b86a5-6d5b.dev.databricks.com/editor/notebooks/2465247895264388?o=1593823105423000#command/7927901211745840

from databricks.sdk import WorkspaceClient
from databricks.sdk.service.serving import ExternalFunctionRequestHttpMethod

WorkspaceClient().serving_endpoints.http_request(
    conn="test_sql_slack",
    method=ExternalFunctionRequestHttpMethod.POST,
    path="/api/chat.postMessage",
    json={"channel": "C07MB25Q6H3", "text": "Hello!"}
)

Tried this and it works

@sunishsheth2009 sunishsheth2009 changed the title Adding the missing super() for open_ai_client [Bugfix] Adding the missing super() for open_ai_client Jan 14, 2025
@sunishsheth2009 sunishsheth2009 changed the title [Bugfix] Adding the missing super() for open_ai_client [Fix] Adding the missing super() for open_ai_client Jan 14, 2025
@sunishsheth2009 sunishsheth2009 changed the title [Fix] Adding the missing super() for open_ai_client [Fix] Fixing http_request open_ai_client mixin Jan 15, 2025
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 859
  • Commit SHA: ee3b9225d74d21695f1f4092eb9f5eec415c0018

Checks will be approved automatically on success.

@sunishsheth2009 sunishsheth2009 deployed to test-trigger-is January 15, 2025 00:47 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant