Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in doc string for select_spark_version #575

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

PawaritL
Copy link
Contributor

@PawaritL PawaritL commented Mar 5, 2024

Changes

Fix typos for argument types for the select_spark_version method. e.g. spark_version should be a string.

Tests

Docs only

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

Signed-off-by: Pawarit Laosunthara <pawarit.laosunthara@databricks.com>
@mgyucht mgyucht added this pull request to the merge queue Mar 13, 2024
Merged via the queue into databricks:main with commit 48c28b1 Mar 13, 2024
7 checks passed
mgyucht added a commit that referenced this pull request Mar 15, 2024
* Fix typos in doc string for select_spark_version ([#575](#575)).

API Changes:

 * Changed `notifications` field for `databricks.sdk.service.catalog.CreateMonitor`, `databricks.sdk.service.catalog.MonitorInfo`, and `databricks.sdk.service.catalog.UpdateMonitor` to `databricks.sdk.service.catalog.MonitorNotificationsConfig` dataclass.
 * Added `browse_only` field for `databricks.sdk.service.catalog.ExternalLocationInfo`, `databricks.sdk.service.catalog.FunctionInfo`, `databricks.sdk.service.catalog.ModelVersionInfo`, `databricks.sdk.service.catalog.RegisteredModelInfo`, `databricks.sdk.service.catalog.SchemaInfo`, `databricks.sdk.service.catalog.TableInfo`, and `databricks.sdk.service.catalog.VolumeInfo`.
 * Added `include_browse` field for `databricks.sdk.service.catalog.GetCatalogRequest`,  `databricks.sdk.service.catalog.GetExternalLocationRequest`,  `databricks.sdk.service.catalog.GetFunctionRequest`,  `databricks.sdk.service.catalog.GetModelVersionRequest`,  `databricks.sdk.service.catalog.GetRegisteredModelRequest`,  `databricks.sdk.service.catalog.GetSchemaRequest`,  `databricks.sdk.service.catalog.GetTableRequest`,  `databricks.sdk.service.catalog.ListExternalLocationsRequest`,  `databricks.sdk.service.catalog.ListFunctionsRequest`,  `databricks.sdk.service.catalog.ListModelVersionsRequest`,  `databricks.sdk.service.catalog.ListRegisteredModelsRequest`,  `databricks.sdk.service.catalog.ListSchemasRequest`,  `databricks.sdk.service.catalog.ListTablesRequest`, `databricks.sdk.service.catalog.ListVolumesRequest`, and `databricks.sdk.service.catalog.ReadVolumeRequest`.
 * Changed `publish()` method for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service to return `databricks.sdk.service.dashboards.PublishedDashboard` dataclass.
 * Added `create()`, `get()`, `get_published()`, `trash()`, and `update()` methods for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service.
 * Added `databricks.sdk.service.dashboards.CreateDashboardRequest`, `databricks.sdk.service.dashboards.Dashboard`, `databricks.sdk.service.dashboards.GetLakeviewRequest`, `databricks.sdk.service.dashboards.GetPublishedRequest`, `databricks.sdk.service.dashboards.LifecycleState`, `databricks.sdk.service.dashboards.PublishedDashboard`, `databricks.sdk.service.dashboards.TrashRequest`, and `databricks.sdk.service.dashboards.UpdateDashboardRequest` dataclasses.

OpenAPI SHA: c84caf9e5ef531cc0b1ddd0a76970d9a8b664e32, Date: 2024-03-15
@mgyucht mgyucht mentioned this pull request Mar 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 15, 2024
* Fix typos in doc string for select_spark_version
([#575](#575)).

API Changes:

* Changed `notifications` field for
`databricks.sdk.service.catalog.CreateMonitor`,
`databricks.sdk.service.catalog.MonitorInfo`, and
`databricks.sdk.service.catalog.UpdateMonitor` to
`databricks.sdk.service.catalog.MonitorNotificationsConfig` dataclass.
* Added `browse_only` field for
`databricks.sdk.service.catalog.ExternalLocationInfo`,
`databricks.sdk.service.catalog.FunctionInfo`,
`databricks.sdk.service.catalog.ModelVersionInfo`,
`databricks.sdk.service.catalog.RegisteredModelInfo`,
`databricks.sdk.service.catalog.SchemaInfo`,
`databricks.sdk.service.catalog.TableInfo`, and
`databricks.sdk.service.catalog.VolumeInfo`.
* Added `include_browse` field for
`databricks.sdk.service.catalog.GetCatalogRequest`,
`databricks.sdk.service.catalog.GetExternalLocationRequest`,
`databricks.sdk.service.catalog.GetFunctionRequest`,
`databricks.sdk.service.catalog.GetModelVersionRequest`,
`databricks.sdk.service.catalog.GetRegisteredModelRequest`,
`databricks.sdk.service.catalog.GetSchemaRequest`,
`databricks.sdk.service.catalog.GetTableRequest`,
`databricks.sdk.service.catalog.ListExternalLocationsRequest`,
`databricks.sdk.service.catalog.ListFunctionsRequest`,
`databricks.sdk.service.catalog.ListModelVersionsRequest`,
`databricks.sdk.service.catalog.ListRegisteredModelsRequest`,
`databricks.sdk.service.catalog.ListSchemasRequest`,
`databricks.sdk.service.catalog.ListTablesRequest`,
`databricks.sdk.service.catalog.ListVolumesRequest`, and
`databricks.sdk.service.catalog.ReadVolumeRequest`.
* Changed `publish()` method for
[w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html)
workspace-level service to return
`databricks.sdk.service.dashboards.PublishedDashboard` dataclass.
* Added `create()`, `get()`, `get_published()`, `trash()`, and
`update()` methods for
[w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html)
workspace-level service.
* Added `databricks.sdk.service.dashboards.CreateDashboardRequest`,
`databricks.sdk.service.dashboards.Dashboard`,
`databricks.sdk.service.dashboards.GetLakeviewRequest`,
`databricks.sdk.service.dashboards.GetPublishedRequest`,
`databricks.sdk.service.dashboards.LifecycleState`,
`databricks.sdk.service.dashboards.PublishedDashboard`,
`databricks.sdk.service.dashboards.TrashRequest`, and
`databricks.sdk.service.dashboards.UpdateDashboardRequest` dataclasses.

OpenAPI SHA: c84caf9e5ef531cc0b1ddd0a76970d9a8b664e32, Date: 2024-03-15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants