Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Binary Logic #516

Closed

Conversation

rportilla-databricks
Copy link

Changes

Wheel created and tested locally

Tests

No additional local tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e37de2c) 57.79% compared to head (ee69dca) 57.79%.

Files Patch % Lines
databricks/sdk/credentials_provider.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   57.79%   57.79%   -0.01%     
==========================================
  Files          43       43              
  Lines       27596    27597       +1     
==========================================
  Hits        15949    15949              
- Misses      11647    11648       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgyucht
Copy link
Contributor

mgyucht commented Feb 1, 2024

This has already been merged in #517.

@mgyucht mgyucht closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants