Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate Python SDK after bumping Deco tool #438

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Nov 13, 2023

Changes

Several changes were made to our codegen tool:

  1. Path parameters will always precede body parameters in methods. This ensures that path parameters always come first, i.e. the ID of the object. This is a pretty bad breaking change for customers, but fortunately only a handful of APIs, primarily update APIs, are affected, namely:
  • AlertsAPI.update
  • DashboardWidgetsAPI.update
  • RecipientsAPI.rotate_token
  • AccountIPAccessListsAPI.update and AccountsIPAccessListsAPI.replace
  • IPAccessListsAPI.update and IPAccessListsAPI.replace
  • ServingEndpointsAPI.update_config and ServingEndpointsAPI.update_config_and_wait
  • PrivateAccessAPI.replace
  • WorkspaceAssignmentsAPI.update
  • GlobalInitScriptsAPI.update
  • MetastoresAPI.assign
  • ConnectionsAPI.update
  • ArtifactAllowlistsAPI.update
  • BudgetsAPI.update
  • LogDeliveryAPI.patch_status
  1. New integration tests were added, so there are new autogenerated examples in the SDK.

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@mgyucht mgyucht requested a review from pietern November 13, 2023 14:53
@mgyucht mgyucht added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 69aa629 Nov 13, 2023
9 checks passed
@mgyucht mgyucht deleted the bump-deco-tool-13-nov-2023 branch November 13, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants