Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken dbutils.fs.mount and dbutils.fs.updateMount #119

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix broken dbutils.fs.mount and dbutils.fs.updateMount #119

merged 2 commits into from
May 17, 2023

Conversation

nfx
Copy link
Contributor

@nfx nfx commented May 17, 2023

Changes

  • add parsing of command execution error contexts
  • fixed broken mounting proxied utilities

Fixes #112

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

_execution_error_re = re.compile(
r'ExecutionError: ([\s\S]*)\n(StatusCode=[0-9]*)\n(StatusDescription=.*)\n')
_error_message_re = re.compile(r'ErrorMessage=(.+)\n')
_ascii_escape_re = re.compile(r'(\x9B|\x1B\[)[0-?]*[ -/]*[@-~]')

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[0-9:;<=>?\].
@nfx nfx merged commit 9e3c83b into main May 17, 2023
@nfx nfx deleted the fix/112 branch May 17, 2023 15:29
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples ([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount` ([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth handshake ([#108](#108)).
* Make ApiClient more `pyodide` friendly ([#114](#114)).
* Persist token acquired through `external-browser` auth type ([#110](#110)).
* Prototype for notebook-native auth ([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials` ([#116](#116)).
* Use shell for opening `az` cli on Windows ([#117](#117)).
@nfx nfx mentioned this pull request May 17, 2023
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples
([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount`
([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth
handshake
([#108](#108)).
* Make ApiClient more `pyodide` friendly
([#114](#114)).
* Persist token acquired through `external-browser` auth type
([#110](#110)).
* Prototype for notebook-native auth
([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials`
([#116](#116)).
* Use shell for opening `az` cli on Windows
([#117](#117)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbutils.fs.mount generates wrong proxy call
1 participant