Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Make userAgent compatible with SQL Drivers #360

Closed

Conversation

samikshya-db
Copy link
Contributor

Changes

  • Currently user Agent does not work with SQL Driver flows. This PR fixes it

Tests

  • Verifed that LogRedactor populates values correctly
  • Added unit tests in this repo too
  • Verified end to end flow using local SDK Jar

@samikshya-db samikshya-db changed the title [PECO-2016] Make userAgent compatible with SQL Drivers [Fix][PECO-2016] Make userAgent compatible with SQL Drivers Oct 11, 2024
@samikshya-db samikshya-db changed the title [Fix][PECO-2016] Make userAgent compatible with SQL Drivers [Fix] Make userAgent compatible with SQL Drivers Oct 11, 2024
@samikshya-db samikshya-db requested a review from mgyucht November 8, 2024 17:13
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-java

Inputs:

  • PR number: 360
  • Commit SHA: ec203207f18fcd208a19ebc1315ebc610cc93215

Checks will be approved automatically on success.

@renaudhartert-db
Copy link
Contributor

Closing this PR as per offline discussions: use agent should be sanitized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants