[Fix] Make UserAgent's otherInfo thread-safe
#357
Merged
+220
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchy
approved these changes
Oct 4, 2024
Comment on lines
+29
to
+33
| public void testConcurrentConfigBasicAuthAttrs( | ||
| @EnvOrSkip("DATABRICKS_HOST") String host, | ||
| @EnvOrSkip("DATABRICKS_CLIENT_ID") String clientId, | ||
| @EnvOrSkip("DATABRICKS_CLIENT_SECRET") String clientSecret) | ||
| throws Exception { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
UserAgent.asString()is called byApiClientevery time a request is made.UserAgentcontains anotherInfolist of additional metadata that users can add to the user agent as needed. If users concurrently modify thisotherInfovalue while iterating through it when making a request,ConcurrentModificationExceptionis thrown.To prevent this, we add
synchronizedblocks around modifying and reading fromotherInfo. Since the time spent constructing the user agent is generally fast, this should not significantly affect performance.I also added a readme describing the new benchmark module with a small contribution guide, and I renamed the existing load test to align with that contribution guide.
Tests
Added a
UserAgentLoadTestto validate that you can safely add tootherInfoand make requests.Added a
WorkspaceClientLoadITto exercise the SDK end-to-end with the SCIM Me request, concurrently.