[Fix] Handle login.html incorrect validation for private link #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3402f7 to
b97e8f3
Compare
b97e8f3 to
5abbb25
Compare
avijeet95
approved these changes
Sep 3, 2024
helfer
reviewed
Sep 3, 2024
There was a problem hiding this comment.
I don't know the codebase, but this would fix the issue we're seeing in our db-sentinel probes for the login page in https://databricks.atlassian.net/browse/ES-1247829. Thank you @satviksr-db!
5abbb25 to
7c45a4b
Compare
7c45a4b to
04c6371
Compare
mgyucht
approved these changes
Sep 3, 2024
mgyucht
added a commit
that referenced
this pull request
Sep 4, 2024
### New Features and Improvements * Add a way to provide non proxy hosts ([#331](#331)). * Add support for discovery URL ([#336](#336)). * Provide SSLSocketFactory in HttpClient ([#333](#333)). ### Bug Fixes * DatabricksConfig: newWithWorkspaceHost should retain authType ([#338](#338)). * Handle login.html incorrect validation for private link ([#340](#340)). ### Internal Changes * Fix nightly test failure ([#339](#339)). ### API Changes: * Added `regenerateDashboard()` method for `workspaceClient.qualityMonitors()` service. * Added `com.databricks.sdk.service.catalog.RegenerateDashboardRequest` and `com.databricks.sdk.service.catalog.RegenerateDashboardResponse` classes. * Added `com.databricks.sdk.service.jobs.QueueDetails`, `com.databricks.sdk.service.jobs.QueueDetailsCodeCode`, `com.databricks.sdk.service.jobs.RunLifecycleStateV2State`, `com.databricks.sdk.service.jobs.RunStatus`, `com.databricks.sdk.service.jobs.TerminationCodeCode`, `com.databricks.sdk.service.jobs.TerminationDetails` and `com.databricks.sdk.service.jobs.TerminationTypeType` classes. * Added `status` field for `com.databricks.sdk.service.jobs.BaseRun`. * Added `status` field for `com.databricks.sdk.service.jobs.RepairHistoryItem`. * Added `status` field for `com.databricks.sdk.service.jobs.Run`. * Added `status` field for `com.databricks.sdk.service.jobs.RunTask`. * Added `maxProvisionedThroughput` and `minProvisionedThroughput` fields for `com.databricks.sdk.service.serving.ServedModelInput`. * Added `columnsToSync` field for `com.databricks.sdk.service.vectorsearch.DeltaSyncVectorIndexSpecRequest`. * Changed `workloadSize` field for `com.databricks.sdk.service.serving.ServedModelInput` to no longer be required. OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
### New Features and Improvements * Add a way to provide non proxy hosts ([#331](#331)). * Add support for discovery URL ([#336](#336)). * Provide SSLSocketFactory in HttpClient ([#333](#333)). ### Bug Fixes * DatabricksConfig: newWithWorkspaceHost should retain authType ([#338](#338)). * Handle login.html incorrect validation for private link ([#340](#340)). ### Internal Changes * Fix nightly test failure ([#339](#339)). ### API Changes: * Added `regenerateDashboard()` method for `workspaceClient.qualityMonitors()` service. * Added `com.databricks.sdk.service.catalog.RegenerateDashboardRequest` and `com.databricks.sdk.service.catalog.RegenerateDashboardResponse` classes. * Added `com.databricks.sdk.service.jobs.QueueDetails`, `com.databricks.sdk.service.jobs.QueueDetailsCodeCode`, `com.databricks.sdk.service.jobs.RunLifecycleStateV2State`, `com.databricks.sdk.service.jobs.RunStatus`, `com.databricks.sdk.service.jobs.TerminationCodeCode`, `com.databricks.sdk.service.jobs.TerminationDetails` and `com.databricks.sdk.service.jobs.TerminationTypeType` classes. * Added `status` field for `com.databricks.sdk.service.jobs.BaseRun`. * Added `status` field for `com.databricks.sdk.service.jobs.RepairHistoryItem`. * Added `status` field for `com.databricks.sdk.service.jobs.Run`. * Added `status` field for `com.databricks.sdk.service.jobs.RunTask`. * Added `maxProvisionedThroughput` and `minProvisionedThroughput` fields for `com.databricks.sdk.service.serving.ServedModelInput`. * Added `columnsToSync` field for `com.databricks.sdk.service.vectorsearch.DeltaSyncVectorIndexSpecRequest`. * Changed `workloadSize` field for `com.databricks.sdk.service.serving.ServedModelInput` to no longer be required. OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
private-link-validation-errorTests
Unit Tests