Fix interrupt handling #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyucht
reviewed
Apr 24, 2024
| @@ -95,7 +95,7 @@ public class {{.PascalName}}API { | |||
| try { | |||
| Thread.sleep((long) (sleep * 1000L + Math.random() * 1000)); | |||
| } catch (InterruptedException e) { | |||
| Thread.currentThread().interrupt(); | |||
| throw new DatabricksException("Current thread was interrupted", e); | |||
There was a problem hiding this comment.
You have to call Thread.currentThread().interrupt() to reset the interrupted bit so that callers will know that this thread was interrupted and can handle such a change.
There was a problem hiding this comment.
I thought that we are already throwing an exception which should be handled by the callers. But I think it won't harm to reset the flag. Just in case someone suppresses the exception, it will still flag the thread as interrupted.
Thanks for catching this. I'll update it as well. |
cc4f56c to
bf74ba0
Compare
mgyucht
approved these changes
Apr 24, 2024
auto-merge was automatically disabled
April 24, 2024 08:44
Head branch was pushed to by a user without write access
03e2351 to
bba0619
Compare
bba0619 to
88d8b6a
Compare
tanmay-db
added a commit
that referenced
this pull request
Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Current implementation does not work well when client interrupts a thread where SDK code is running. Once interrupted, the logic continues to run till the timeout (default 20mins) without sleeping at all. Each time thread.sleep is called, it throws interrupt exception and this results in calling the status API continuously without delay.
The PR is changing the handling to throw DatabricksException when the thread is interrupted so that clients can stop the processing and handle the exception as they wish.
Tests
All unit tests are successful.