Fix one shot pagination #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
approved these changes
Apr 22, 2024
vikrantpuppala
pushed a commit
to vikrantpuppala/databricks-sdk-java
that referenced
this pull request
Apr 23, 2024
## Changes databricks#266 unintentionally broke one-shot list APIs because the single page would never be fetched. This PR forces that first page to be fetched, restoring the original behavior. ## Tests - [x] Ran SecretsIT locally, and it worked.
tanmay-db
added a commit
that referenced
this pull request
Apr 23, 2024
* [PECO-1008] Add retry strategy based on idempotency of requests ([#264](#264)). * Fix remaining Java integration tests ([#265](#265)). * Fix one-shot list APIs to not return null ([#266](#266)). * Remove unnecessary secret from example ([#267](#267)). * Fix one shot pagination ([#268](#268)). * Update SDK to OpenAPI spec ([#269](#269)). * [PECO-1542] Add a way to provide proxy details to SDK ([#271](#271)). API Changes: * Added `schemaId` field for `com.databricks.sdk.service.catalog.SchemaInfo`. * Removed `awsOperation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Removed `azureOperation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Removed `gcpOperation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Added `operation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Removed `com.databricks.sdk.service.catalog.ValidationResultAwsOperation` class. * Removed `com.databricks.sdk.service.catalog.ValidationResultAzureOperation` class. * Removed `com.databricks.sdk.service.catalog.ValidationResultGcpOperation` class. * Added `com.databricks.sdk.service.catalog.ValidationResultOperation` class. * Changed `clusterStatus()` method for `workspaceClient.libraries()` service . New request type is `com.databricks.sdk.service.compute.ClusterStatus` class. * Changed `clusterStatus()` method for `workspaceClient.libraries()` service to return `com.databricks.sdk.service.compute.ClusterStatusResponse` class. * Removed `com.databricks.sdk.service.compute.ClusterStatusRequest` class. * Added `requirements` field for `com.databricks.sdk.service.compute.Library`. * Changed `status` field for `com.databricks.sdk.service.compute.LibraryFullStatus` to `com.databricks.sdk.service.compute.LibraryInstallStatus` class. * Removed `com.databricks.sdk.service.compute.LibraryFullStatusStatus` class. * Added `com.databricks.sdk.service.compute.ClusterStatus` class. * Added `com.databricks.sdk.service.compute.ClusterStatusResponse` class. * Added `com.databricks.sdk.service.compute.LibraryInstallStatus` class. * Added `warehouseId` field for `com.databricks.sdk.service.jobs.NotebookTask`. * Added `runAs` field for `com.databricks.sdk.service.jobs.SubmitRun`. * Added `deployment` field for `com.databricks.sdk.service.pipelines.CreatePipeline`. * Added `deployment` field for `com.databricks.sdk.service.pipelines.EditPipeline`. * Added `deployment` field for `com.databricks.sdk.service.pipelines.PipelineSpec`. * Added `com.databricks.sdk.service.pipelines.DeploymentKind` class. * Added `com.databricks.sdk.service.pipelines.PipelineDeployment` class. OpenAPI SHA: 06d330f43d92c1be864d4638c672cd0723e20a51, Date: 2024-04-22
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
## 0.24.0 * Added retry strategy based on idempotency of requests ([#264](#264)). * Fixde remaining Java integration tests ([#265](#265)). * Fixed one-shot list APIs to not return null ([#266](#266)). * Removed unnecessary secret from example ([#267](#267)). * Fixed one shot pagination ([#268](#268)). * Updated SDK to OpenAPI spec ([#269](#269)). * Added a way to provide proxy details to SDK ([#271](#271)). Note: This release contains breaking changes, please see the API changes below for more details. API Changes: * Added `deployment` field for `com.databricks.sdk.service.pipelines.CreatePipeline`, `com.databricks.sdk.service.pipelines.EditPipeline`, `com.databricks.sdk.service.pipelines.PipelineSpec`. * Added `schemaId` field for `com.databricks.sdk.service.catalog.SchemaInfo`. * Added `operation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Added `requirements` field for `com.databricks.sdk.service.compute.Library`. * Added `warehouseId` field for `com.databricks.sdk.service.jobs.NotebookTask`. * Added `runAs` field for `com.databricks.sdk.service.jobs.SubmitRun`. * Added `com.databricks.sdk.service.catalog.ValidationResultOperation` class. * Added `com.databricks.sdk.service.compute.ClusterStatus` class. * Added `com.databricks.sdk.service.compute.ClusterStatusResponse` class. * Added `com.databricks.sdk.service.compute.LibraryInstallStatus` class. * Added `com.databricks.sdk.service.pipelines.DeploymentKind` class. * Added `com.databricks.sdk.service.pipelines.PipelineDeployment` class. * Removed `awsOperation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Removed `azureOperation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Removed `gcpOperation` field for `com.databricks.sdk.service.catalog.ValidationResult`. * Removed `com.databricks.sdk.service.catalog.ValidationResultAwsOperation` class. * Removed `com.databricks.sdk.service.catalog.ValidationResultAzureOperation` class. * Removed `com.databricks.sdk.service.catalog.ValidationResultGcpOperation` class. * Removed `com.databricks.sdk.service.compute.ClusterStatusRequest` class. * Removed `com.databricks.sdk.service.compute.LibraryFullStatusStatus` class. * Changed `clusterStatus()` method for `workspaceClient.libraries()` service . New request type is `com.databricks.sdk.service.compute.ClusterStatus` class. * Changed `clusterStatus()` method for `workspaceClient.libraries()` service to return `com.databricks.sdk.service.compute.ClusterStatusResponse` class. * Changed `status` field for `com.databricks.sdk.service.compute.LibraryFullStatus` to `com.databricks.sdk.service.compute.LibraryInstallStatus` class. OpenAPI SHA: 06d330f43d92c1be864d4638c672cd0723e20a51, Date: 2024-04-22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#266 unintentionally broke one-shot list APIs because the single page would never be fetched. This PR forces that first page to be fetched, restoring the original behavior.
Tests