Upgrade Go SDK to 0.44.0 #1679
Merged
Upgrade Go SDK to 0.44.0 #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
commented
Aug 14, 2024
| @@ -53,15 +53,15 @@ func (r *pipelineRunner) logErrorEvent(ctx context.Context, pipelineId string, u | |||
| // Otherwise for long lived pipelines, there can be a lot of unnecessary | |||
| // latency due to multiple pagination API calls needed underneath the hood for | |||
| // ListPipelineEventsAll | |||
| res, err := w.Pipelines.Impl().ListPipelineEvents(ctx, pipelines.ListPipelineEventsRequest{ | |||
| events, err := w.Pipelines.ListPipelineEventsAll(ctx, pipelines.ListPipelineEventsRequest{ | |||
There was a problem hiding this comment.
Impl is not exposed from Go SDK anymore
andrewnester
commented
Aug 14, 2024
| @@ -78,7 +78,7 @@ func (l *UpdateTracker) Events(ctx context.Context) ([]ProgressEvent, error) { | |||
| } | |||
|
|
|||
| // we only check the most recent 100 events for progress | |||
| response, err := l.w.Pipelines.Impl().ListPipelineEvents(ctx, pipelines.ListPipelineEventsRequest{ | |||
| events, err := l.w.Pipelines.ListPipelineEventsAll(ctx, pipelines.ListPipelineEventsRequest{ | |||
There was a problem hiding this comment.
Impl is not exposed from Go SDK anymore
andrewnester
commented
Aug 14, 2024
| all, err := w.Clusters.ListAll(ctx, compute.ListClustersRequest{ | ||
| CanUseClient: "NOTEBOOKS", | ||
| }) | ||
| all, err := w.Clusters.ListAll(ctx, compute.ListClustersRequest{}) |
There was a problem hiding this comment.
ListAll does not support CanUseClient anymore because API backend does not provide this capability
pietern
approved these changes
Aug 15, 2024
andrewnester
added a commit
that referenced
this pull request
Aug 15, 2024
CLI: * Add command line autocomplete to the fs commands ([#1622](#1622)). * Add trailing slash to directory to produce completions for ([#1666](#1666)). * Fix ability to import the CLI repository as module ([#1671](#1671)). * Fix host resolution order in `auth login` ([#1370](#1370)). * Print text logs in `import-dir` and `export-dir` commands ([#1682](#1682)). Bundles: * Expand and upload local wheel libraries for all task types ([#1649](#1649)). * Clarify file format required for the `config-file` flag in `bundle init` ([#1651](#1651)). * Fixed incorrectly cleaning up python wheel dist folder ([#1656](#1656)). * Merge job parameters based on their name ([#1659](#1659)). * Fix glob expansion after running a generic build command ([#1662](#1662)). * Upload local libraries even if they don't have artifact defined ([#1664](#1664)). Internal: * Fix python wheel task integration tests ([#1648](#1648)). * Skip pushing Terraform state after destroy ([#1667](#1667)). * Enable Spark JAR task test ([#1658](#1658)). * Run Spark JAR task test on multiple DBR versions ([#1665](#1665)). * Stop tracking file path locations in bundle resources ([#1673](#1673)). * Update VS Code settings to match latest value from IDE plugin ([#1677](#1677)). * Use `service.NamedIdMap` to make lookup generation deterministic ([#1678](#1678)). * [Internal] Remove dependency to the `openapi` package of the Go SDK ([#1676](#1676)). * Upgrade TF provider to 1.50.0 ([#1681](#1681)). * Upgrade Go SDK to 0.44.0 ([#1679](#1679)). API Changes: * Changed `databricks account budgets create` command . New request type is . * Changed `databricks account budgets create` command to return . * Changed `databricks account budgets delete` command . New request type is . * Changed `databricks account budgets delete` command to return . * Changed `databricks account budgets get` command . New request type is . * Changed `databricks account budgets get` command to return . * Changed `databricks account budgets list` command to require request of . * Changed `databricks account budgets list` command to return . * Changed `databricks account budgets update` command . New request type is . * Changed `databricks account budgets update` command to return . * Added `databricks account usage-dashboards` command group. * Changed `databricks model-versions get` command to return . * Changed `databricks cluster-policies create` command with new required argument order. * Changed `databricks cluster-policies edit` command with new required argument order. * Added `databricks clusters update` command. * Added `databricks genie` command group. * Changed `databricks permission-migration migrate-permissions` command . New request type is . * Changed `databricks permission-migration migrate-permissions` command to return . * Changed `databricks account workspace-assignment delete` command to return . * Changed `databricks account workspace-assignment update` command with new required argument order. * Changed `databricks account custom-app-integration create` command with new required argument order. * Changed `databricks account custom-app-integration list` command to require request of . * Changed `databricks account published-app-integration list` command to require request of . * Removed `databricks apps` command group. * Added `databricks notification-destinations` command group. * Changed `databricks shares list` command to require request of . * Changed `databricks alerts create` command . New request type is . * Changed `databricks alerts delete` command . New request type is . * Changed `databricks alerts delete` command to return . * Changed `databricks alerts get` command with new required argument order. * Changed `databricks alerts list` command to require request of . * Changed `databricks alerts list` command to return . * Changed `databricks alerts update` command . New request type is . * Changed `databricks alerts update` command to return . * Changed `databricks queries create` command . New request type is . * Changed `databricks queries delete` command . New request type is . * Changed `databricks queries delete` command to return . * Changed `databricks queries get` command with new required argument order. * Changed `databricks queries list` command to return . * Removed `databricks queries restore` command. * Changed `databricks queries update` command . New request type is . * Added `databricks queries list-visualizations` command. * Changed `databricks query-visualizations create` command . New request type is . * Changed `databricks query-visualizations delete` command . New request type is . * Changed `databricks query-visualizations delete` command to return . * Changed `databricks query-visualizations update` command . New request type is . * Changed `databricks statement-execution execute-statement` command to return . * Changed `databricks statement-execution get-statement` command to return . * Added `databricks alerts-legacy` command group. * Added `databricks queries-legacy` command group. * Added `databricks query-visualizations-legacy` command group. OpenAPI commit f98c07f9c71f579de65d2587bb0292f83d10e55d (2024-08-12) Dependency updates: * Bump github.com/hashicorp/hc-install from 0.7.0 to 0.8.0 ([#1652](#1652)). * Bump golang.org/x/sync from 0.7.0 to 0.8.0 ([#1655](#1655)). * Bump golang.org/x/mod from 0.19.0 to 0.20.0 ([#1654](#1654)). * Bump golang.org/x/oauth2 from 0.21.0 to 0.22.0 ([#1653](#1653)). * Bump golang.org/x/text from 0.16.0 to 0.17.0 ([#1670](#1670)). * Bump golang.org/x/term from 0.22.0 to 0.23.0 ([#1669](#1669)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
CLI: * Add command line autocomplete to the fs commands ([#1622](#1622)). * Add trailing slash to directory to produce completions for ([#1666](#1666)). * Fix ability to import the CLI repository as module ([#1671](#1671)). * Fix host resolution order in `auth login` ([#1370](#1370)). * Print text logs in `import-dir` and `export-dir` commands ([#1682](#1682)). Bundles: * Expand and upload local wheel libraries for all task types ([#1649](#1649)). * Clarify file format required for the `config-file` flag in `bundle init` ([#1651](#1651)). * Fixed incorrectly cleaning up python wheel dist folder ([#1656](#1656)). * Merge job parameters based on their name ([#1659](#1659)). * Fix glob expansion after running a generic build command ([#1662](#1662)). * Upload local libraries even if they don't have artifact defined ([#1664](#1664)). Internal: * Fix python wheel task integration tests ([#1648](#1648)). * Skip pushing Terraform state after destroy ([#1667](#1667)). * Enable Spark JAR task test ([#1658](#1658)). * Run Spark JAR task test on multiple DBR versions ([#1665](#1665)). * Stop tracking file path locations in bundle resources ([#1673](#1673)). * Update VS Code settings to match latest value from IDE plugin ([#1677](#1677)). * Use `service.NamedIdMap` to make lookup generation deterministic ([#1678](#1678)). * [Internal] Remove dependency to the `openapi` package of the Go SDK ([#1676](#1676)). * Upgrade TF provider to 1.50.0 ([#1681](#1681)). * Upgrade Go SDK to 0.44.0 ([#1679](#1679)). API Changes: * Changed `databricks account budgets create` command . New request type is . * Changed `databricks account budgets create` command to return . * Changed `databricks account budgets delete` command . New request type is . * Changed `databricks account budgets delete` command to return . * Changed `databricks account budgets get` command . New request type is . * Changed `databricks account budgets get` command to return . * Changed `databricks account budgets list` command to require request of . * Changed `databricks account budgets list` command to return . * Changed `databricks account budgets update` command . New request type is . * Changed `databricks account budgets update` command to return . * Added `databricks account usage-dashboards` command group. * Changed `databricks model-versions get` command to return . * Changed `databricks cluster-policies create` command with new required argument order. * Changed `databricks cluster-policies edit` command with new required argument order. * Added `databricks clusters update` command. * Added `databricks genie` command group. * Changed `databricks permission-migration migrate-permissions` command . New request type is . * Changed `databricks permission-migration migrate-permissions` command to return . * Changed `databricks account workspace-assignment delete` command to return . * Changed `databricks account workspace-assignment update` command with new required argument order. * Changed `databricks account custom-app-integration create` command with new required argument order. * Changed `databricks account custom-app-integration list` command to require request of . * Changed `databricks account published-app-integration list` command to require request of . * Removed `databricks apps` command group. * Added `databricks notification-destinations` command group. * Changed `databricks shares list` command to require request of . * Changed `databricks alerts create` command . New request type is . * Changed `databricks alerts delete` command . New request type is . * Changed `databricks alerts delete` command to return . * Changed `databricks alerts get` command with new required argument order. * Changed `databricks alerts list` command to require request of . * Changed `databricks alerts list` command to return . * Changed `databricks alerts update` command . New request type is . * Changed `databricks alerts update` command to return . * Changed `databricks queries create` command . New request type is . * Changed `databricks queries delete` command . New request type is . * Changed `databricks queries delete` command to return . * Changed `databricks queries get` command with new required argument order. * Changed `databricks queries list` command to return . * Removed `databricks queries restore` command. * Changed `databricks queries update` command . New request type is . * Added `databricks queries list-visualizations` command. * Changed `databricks query-visualizations create` command . New request type is . * Changed `databricks query-visualizations delete` command . New request type is . * Changed `databricks query-visualizations delete` command to return . * Changed `databricks query-visualizations update` command . New request type is . * Changed `databricks statement-execution execute-statement` command to return . * Changed `databricks statement-execution get-statement` command to return . * Added `databricks alerts-legacy` command group. * Added `databricks queries-legacy` command group. * Added `databricks query-visualizations-legacy` command group. OpenAPI commit f98c07f9c71f579de65d2587bb0292f83d10e55d (2024-08-12) Dependency updates: * Bump github.com/hashicorp/hc-install from 0.7.0 to 0.8.0 ([#1652](#1652)). * Bump golang.org/x/sync from 0.7.0 to 0.8.0 ([#1655](#1655)). * Bump golang.org/x/mod from 0.19.0 to 0.20.0 ([#1654](#1654)). * Bump golang.org/x/oauth2 from 0.21.0 to 0.22.0 ([#1653](#1653)). * Bump golang.org/x/text from 0.16.0 to 0.17.0 ([#1670](#1670)). * Bump golang.org/x/term from 0.22.0 to 0.23.0 ([#1669](#1669)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade Go SDK to 0.44.0