You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that, when managing pipelines via pypiper, if the results already exist, the pipeline will fail. This is because pypiper uses pipestat to report and does not use pipestat.report's force_overwrite parameter:
These results exist for 'DEFAULT_SAMPLE_NAME': Read_type
Traceback (most recent call last):
File "/home/drc/pepatac_tutorial//tools/pepatac/pipelines/pepatac.py", line 2779, in <module>
sys.exit(main())
File "/home/drc/pepatac_tutorial//tools/pepatac/pipelines/pepatac.py", line 731, in main
pm.report_result("Read_type", args.single_or_paired)
File "/home/drc/anaconda3/envs/pepatac38/lib/python3.8/site-packages/pypiper/manager.py", line 1615, in report_result
for r in reported_result:
TypeError: 'bool' object is not iterable
pipestat.report returns False if it cannot report the result which then causes an issue in line 1691.
Solution:
-create a new parameter in pypiper that allows the user to toggle force_overwrite and default it to False.
-implement handling a False value instead of crashing pypiper.
The text was updated successfully, but these errors were encountered:
* try getting just stage name, but fall back to str representation of stage; close#197
* version 0.13.3a1 for pipestat 0.6.0a1
* updated to pipestat 0.6.0
* updated requirements
* testing, drop python 3.7
* fix f-string quote issue for python 3.10
* minor refactor to use pipestat properties instead of cfg dict
* update changelog and version number
* update v0.13.3 and changelog
* fix _refresh_stats bug and change version to 0.14.0
* potential fix for #201
* changelog
* v0.14.0a1 prerelease
* report_object -> change message_raw to be a values dict to conform with pipestat output schemas
* self.pipestat_results_file should take priority over self.pipeline_stats_file related to databio/pepatac#257
* make pipestat_results_file = pipeline_stats_file if it is not provided
* set pipeline_stats_file if pipestat_results_file IS provided, remove checking for the first record_identifier during get_stat
* add pipestat_pipeline_type, defaulting to sample
* pipestat req version bump, v0.14.0a2 bump for pre-release
* v0.14.0 release prep
---------
Co-authored-by: Vince Reuter <vince.reuter@gmail.com>
Co-authored-by: Khoroshevskyi <sasha99250@gmail.com>
I noticed that, when managing pipelines via pypiper, if the results already exist, the pipeline will fail. This is because pypiper uses pipestat to report and does not use
pipestat.report
'sforce_overwrite
parameter:pypiper/pypiper/manager.py
Lines 1686 to 1692 in 8aaede5
Example of error (while using PEPATAC):
pipestat.report
returnsFalse
if it cannot report the result which then causes an issue in line 1691.Solution:
-create a new parameter in pypiper that allows the user to toggle
force_overwrite
and default it to False.-implement handling a
False
value instead of crashing pypiper.The text was updated successfully, but these errors were encountered: