Improve: make sending rpc-response a command and enqueue it in the command list #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand list Sending rpc(vote, append-entries and install-snapshot) response must be after executing the commands generated by Engine. Thus introduce `Command` for doing such actions, e.g., `tx.send(res)`. Command execution can be reordered or batched for performance. Because `oneshot::Sender` is not `Clone`, `Command` and other related types that includes it are adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Improve: make sending rpc-response a command and enqueue it in the command list
Sending rpc(vote, append-entries and install-snapshot) response must be
after executing the commands generated by Engine.
Thus introduce
Commandfor doing such actions, e.g.,tx.send(res).Command execution can be reordered or batched for performance.
Because
oneshot::Senderis notClone,Commandand other related types that includes it are adjusted.Refactor: vote checking and handling is same for every incoming event.
This change is