Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(meta/config): Adapt RFC Config Backward Compatibility #5421

Merged
merged 5 commits into from
May 18, 2022
Merged

refactor(meta/config): Adapt RFC Config Backward Compatibility #5421

merged 5 commits into from
May 18, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 17, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Part of #5297

After this PR, databend-meta will maintain config backward compatibility.

Changelog

  • Improvement

@Xuanwo
Implement Config Backward Compatibility for metasrv
a7d1ef5 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from BohuTANG as a code owner May 17, 2022 06:59
@vercel
Copy link

vercel bot commented May 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 18, 2022 at 6:52AM (UTC)

@Xuanwo Xuanwo requested review from lichuang and drmingdrmer May 17, 2022 06:59
@mergify
Copy link
Contributor

mergify bot commented May 17, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@Xuanwo
Copy link
Member Author

Xuanwo commented May 17, 2022 •
edited
Loading

@drmingdrmer @lichuang metasrv config is so wired that confused with metasrv_xxx and kv_xxx, how about deprecating all kv_xxx configs in the future? In this PR, we will just migrate them as is without any changes.

@Xuanwo Xuanwo mentioned this pull request May 17, 2022
Closed
6 tasks
Xuanwo added 2 commits May 17, 2022 15:14
@Xuanwo
Make taplo happy
705499f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Make sure value from args parsed correctly
3907275 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented May 17, 2022 •
edited
Loading

While addressing the comment @drmingdrmer proposed, I found other serious bugs.

I will convert this PR to draft until I figure it out.

@Xuanwo Xuanwo marked this pull request as draft May 17, 2022 10:21
@Xuanwo
Copy link
Member Author

Xuanwo commented May 17, 2022 •
edited
Loading

In short, serde doesn't work correctly along with alias: serde-rs/serde#1519

It seems we need to do the dirty work by hand.

@Xuanwo
Fix unit tests
dfe8696 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review May 18, 2022 06:48
@Xuanwo
Copy link
Member Author

Xuanwo commented May 18, 2022 •
edited
Loading

@drmingdrmer @lichuang Please take a look.

@BohuTANG BohuTANG requested a review from drmingdrmer May 18, 2022 08:20
drmingdrmer
drmingdrmer approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and neat

@BohuTANG BohuTANG merged commit 75d7336 into databendlabs:main May 18, 2022
@Xuanwo Xuanwo deleted the rfc-5324-meta-config branch May 18, 2022 11:44
@Xuanwo Xuanwo mentioned this pull request May 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@lichuang lichuang Awaiting requested review from lichuang

Assignees
No one assigned
Labels
need-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @drmingdrmer @BohuTANG @databend-bot