refactor(query/config/storage): Adapt RFC Config Backward Compatibility #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Signed-off-by: Xuanwo <github@xuanwo.io>
6 tasks
sundy-li
approved these changes
May 16, 2022
Signed-off-by: Xuanwo <github@xuanwo.io>
flaneur2020
approved these changes
May 16, 2022
Signed-off-by: Xuanwo <github@xuanwo.io>
|
Some stage-related tests is broken, I'm working on it. |
Signed-off-by: Xuanwo <github@xuanwo.io>
…-5324-query-storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Part of #5297
This PR adds an outer config for
queryConfig:OuterConfigV0.We will make sure that:
TryFrom OuterConfigV0 Into ConfigFrom Config Into OuterConfigV0Config.config.into_outer()to expose OuterConfigV0In this PR, we refactor
StorageConfigin an enum, so that we can use storage-related configs with confidence.Only
StorageConfighas been adapted, other config fields will be updated in the following PRs.Changelog