Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support interval type #517

Merged
merged 3 commits into from
Dec 4, 2024
Merged

feat: support interval type #517

merged 3 commits into from
Dec 4, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Dec 3, 2024

No description provided.

@TCeason TCeason force-pushed the add_interval branch 2 times, most recently from 9820c01 to f3665f8 Compare December 3, 2024 09:45
@TCeason TCeason changed the title support interval type feat: support interval type Dec 3, 2024
@TCeason TCeason force-pushed the add_interval branch 3 times, most recently from 8e64fe2 to b45b8f6 Compare December 3, 2024 10:25
@TCeason TCeason requested a review from sundy-li December 3, 2024 10:41
everpcpc
everpcpc reviewed Dec 3, 2024
View reviewed changes
sql/src/value.rs Outdated Show resolved Hide resolved
everpcpc
everpcpc reviewed Dec 3, 2024
View reviewed changes
sql/src/value.rs Outdated Show resolved Hide resolved
@TCeason TCeason force-pushed the add_interval branch 2 times, most recently from 974c73c to e4db29d Compare December 3, 2024 12:27
@TCeason TCeason mentioned this pull request Dec 4, 2024
Merged
11 tasks
@TCeason
Copy link
Collaborator Author

TCeason commented Dec 4, 2024

Use bendsql: Now support nanos cc @sundy-li Please review this pr.

:) select * from t2 ;

SELECT * FROM t2

┌─────────────────────────────────────────┐
│ c1 │ c2 │
│ Nullable(Interval) │ Nullable(Interval) │
├────────────────────┼────────────────────┤
│ 1 month │ 0:00:00.000000001 │
└─────────────────────────────────────────┘

@TCeason
refactor Interval
670a4da 
pub struct Interval {
    pub months: i32,
    pub days: i32,
    pub nanos: i64,
}
@sundy-li sundy-li merged commit 30d3874 into databendlabs:main Dec 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@everpcpc everpcpc everpcpc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TCeason @everpcpc @sundy-li