chore: handle warnings from backend #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a61d62d to
9ea366f
Compare
everpcpc
reviewed
Dec 12, 2023
| @@ -61,6 +61,7 @@ pub struct QueryResponse { | |||
| pub data: Vec<Vec<String>>, | |||
| pub state: String, | |||
| pub error: Option<QueryError>, | |||
| pub warnings: Vec<String>, | |||
There was a problem hiding this comment.
Option<Vec<String>> for backward compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we added an extra
warningsfield in the response from query.on some corner cases when some tables are failed to be listed in the
SHOW TABLESstatement, we'd perfer returnwarningsinstead of errors, which would break all the output.