Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support python binding #112

Merged
merged 21 commits into from
May 25, 2023
Merged

feat: Support python binding #112

merged 21 commits into from
May 25, 2023

Conversation

hantmac
Copy link
Member

@hantmac hantmac commented May 10, 2023

  • Support python binding

everpcpc
everpcpc reviewed May 11, 2023
View reviewed changes
driver/src/conn.rs Outdated Show resolved Hide resolved
@hantmac hantmac marked this pull request as draft May 12, 2023 03:58
@hantmac hantmac marked this pull request as ready for review May 15, 2023 03:39
@everpcpc
Copy link
Member

add some test?

@hantmac hantmac force-pushed the feat/python-binding branch from 62cc6ef to 80cf196 Compare May 23, 2023 06:40
everpcpc
everpcpc reviewed May 23, 2023
View reviewed changes
bindings/python/README.md Outdated Show resolved Hide resolved
@hantmac hantmac marked this pull request as draft May 23, 2023 08:59
everpcpc
everpcpc reviewed May 23, 2023
View reviewed changes
driver/src/conn.rs Outdated Show resolved Hide resolved
everpcpc
everpcpc reviewed May 23, 2023
View reviewed changes
driver/src/rest_api.rs Outdated Show resolved Hide resolved
@hantmac hantmac marked this pull request as ready for review May 23, 2023 12:57
@hantmac hantmac requested a review from everpcpc May 23, 2023 12:57
everpcpc
everpcpc reviewed May 23, 2023
View reviewed changes
driver/src/lib.rs Outdated Show resolved Hide resolved
everpcpc
everpcpc reviewed May 23, 2023
View reviewed changes
core/src/client.rs Outdated Show resolved Hide resolved
everpcpc
everpcpc reviewed May 23, 2023
View reviewed changes
driver/src/flight_sql.rs Outdated Show resolved Hide resolved
@hantmac hantmac force-pushed the feat/python-binding branch from 1f2f99a to b5a1c8d Compare May 24, 2023 02:48
everpcpc
everpcpc approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@everpcpc everpcpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@everpcpc
Copy link
Member

cc @sundy-li @Xuanwo pls take a look ?

Xuanwo
Xuanwo approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, let's merge first!

@everpcpc everpcpc merged commit 77eb039 into databendlabs:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@sundy-li sundy-li sundy-li approved these changes

@everpcpc everpcpc everpcpc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hantmac @everpcpc @sundy-li @Xuanwo