Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry delete run on db failure #420

Merged
merged 7 commits into from
Sep 6, 2019
Merged

Retry delete run on db failure #420

merged 7 commits into from
Sep 6, 2019

Conversation

hardbyte
Copy link
Collaborator

@hardbyte hardbyte commented Sep 6, 2019

This won't definitively close the root cause of issue #419 but should at least handle the flaky behavior.

@hardbyte hardbyte requested a review from wilko77 September 6, 2019 01:07
wilko77
wilko77 requested changes Sep 6, 2019
View reviewed changes
Copy link
Collaborator

@wilko77 wilko77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not use unmaintained dependencies

backend/entityservice/views/run/description.py Outdated Show resolved Hide resolved
backend/entityservice/views/run/description.py Outdated Show resolved Hide resolved
@hardbyte hardbyte requested a review from wilko77 September 6, 2019 02:37
wilko77
wilko77 approved these changes Sep 6, 2019
View reviewed changes
backend/entityservice/views/run/description.py Outdated Show resolved Hide resolved
@hardbyte hardbyte merged commit f5ab3b8 into develop Sep 6, 2019
@hardbyte hardbyte deleted the fix-delete-run-race-condition branch September 6, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilko77 wilko77 wilko77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardbyte @wilko77