fix: replace exposed site header method with nav link emitter

data-preservation-programs · Sep 8, 2023 · 20329da · 20329da
1 parent a0d14e1
commit 20329da
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/components/navbar.vue b/components/navbar.vue
@@ -32,11 +32,11 @@ const props = defineProps({
   }
 })
 
-const instance = getCurrentInstance()
+const emit = defineEmits(['nav-link-click'])
 
 // ===================================================================== Methods
 const scrollToSection = async (el) => {
-  instance.parent.exposed.handleNavClick()
+  emit('nav-link-click')
   const id = el.replaceAll('#', '')
   const section = document.getElementById(id)
   if (section) {

diff --git a/components/site-header.vue b/components/site-header.vue
@@ -11,7 +11,8 @@
           <div class="mobile-nav">
             <Navbar
               :links="navigation"
-              class="mobile">
+              class="mobile"
+              @nav-link-click="handleNavClick">
               <div class="nav-item">
                 <ButtonCta
                   tag="nuxt-link"
@@ -169,8 +170,6 @@ const handleNavClick = () => {
   if (navigationOpen.value) { toggleNav() }
 }
 
-defineExpose({ handleNavClick })
-
 </script>
 
 <style lang="scss" scoped>