Add support for multiple challenges per level #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-pl
commented
Nov 8, 2023
7f3ac67 to
2d4e263
Compare
jcace
reviewed
Nov 8, 2023
jcace
reviewed
Nov 8, 2023
jcace
reviewed
Nov 8, 2023
jcace
reviewed
Nov 8, 2023
jcace
reviewed
Nov 8, 2023
jcace
reviewed
Nov 8, 2023
jcace
reviewed
Nov 8, 2023
e84c0f2 to
4fe9b4a
Compare
jcace
reviewed
Nov 27, 2023
pkg/net/bitswap.go
Outdated
|
|
||
| i++ // To the next layer of the tree | ||
| func getMaxChallengesPerLevel(logger *zap.SugaredLogger) int { |
There was a problem hiding this comment.
seems a bit weird that it needs a logger to be passed in to call this, I think it's cleaner if this thing initializes its own logging.Logger, or alternatively move the body of this function into the calling code as it's only used in one place anyways.
jcace
approved these changes
Nov 27, 2023
e1602c7 to
d868d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.