-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Change any mention of "HTTP Retrieval" to "HTTP Piece Retrieval" #44
Comments
@xmcai2016 I dont notice any http retrieval mentioned in the code. Is this task to change things like HTTP Total Call Count Last 30 days |
Yes it's referring to the front end (RB vercel dashboard), I should've been
more clear
…On Thu, Oct 19, 2023 at 11:43 AM stephen-pl ***@***.***> wrote:
@xmcai2016 <https://github.com/xmcai2016> I dont notice any http
retrieval mentioned in the code. Is this task to change things like
HTTP Total Call Count Last 30 days
HTTP Piece RetrievalTotal Call Count Last 30 days
—
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFLE2776AND2Q2ZJ456OZ2LYAFDDPAVCNFSM6AAAAAA5PNUSSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRGI2TEMBYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The http inside the bar graphs come from the data in the db so not sure if we want to change that to be http_piece. We can just let me know |
You mean in places like this? I don't think it's worth changing it just yet. @stephen-pl Btw in your previous screenshot above, PIECE is all caps and could be confusing, let's change them back to lowercase :D |
Yes the places inside the graph. Will do that was just a quick change to understand if those were the places you were thinking about the changes. Ill have the pr out and merged soon to change HTTP to HTTP Piece in the side bar and the total counts |
https://filecoinproject.slack.com/archives/C03UVDVVCDR/p1696252213163749?thread_ts=1696239051.458289&cid=C03UVDVVCDR
The text was updated successfully, but these errors were encountered: