Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Change any mention of "HTTP Retrieval" to "HTTP Piece Retrieval" #44

Closed
Tracked by #17
xmcai2016 opened this issue Oct 2, 2023 · 6 comments
Closed
Tracked by #17
Assignees

Comments

@xmcai2016
Copy link

xmcai2016 commented Oct 2, 2023

https://filecoinproject.slack.com/archives/C03UVDVVCDR/p1696252213163749?thread_ts=1696239051.458289&cid=C03UVDVVCDR

Image

@xmcai2016 xmcai2016 converted this from a draft issue Oct 2, 2023
@xmcai2016 xmcai2016 assigned stephen-pl and unassigned 10d9e Oct 12, 2023
@stephen-pl stephen-pl moved this from 🍇 Backlog to 🍰 Todo / Commited in ActionArena Oct 17, 2023
@stephen-pl
Copy link
Contributor

@xmcai2016 I dont notice any http retrieval mentioned in the code. Is this task to change things like

HTTP Total Call Count Last 30 days
HTTP Piece RetrievalTotal Call Count Last 30 days

@stephen-pl stephen-pl moved this from 🍰 Todo / Commited to 👨‍💻 In Progress in ActionArena Oct 19, 2023
@xmcai2016
Copy link
Author

xmcai2016 commented Oct 19, 2023 via email

@stephen-pl
Copy link
Contributor

Solike
image

@stephen-pl
Copy link
Contributor

The http inside the bar graphs come from the data in the db so not sure if we want to change that to be http_piece. We can just let me know

@xmcai2016
Copy link
Author

You mean in places like this? I don't think it's worth changing it just yet. @stephen-pl
image

Btw in your previous screenshot above, PIECE is all caps and could be confusing, let's change them back to lowercase :D

@stephen-pl
Copy link
Contributor

Yes the places inside the graph.

Will do that was just a quick change to understand if those were the places you were thinking about the changes.

Ill have the pr out and merged soon to change HTTP to HTTP Piece in the side bar and the total counts

@stephen-pl stephen-pl moved this from 👨‍💻 In Progress to 🚢 Done in ActionArena Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚢 Done
Development

No branches or pull requests

3 participants