Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex scalar checking and test_square failure #204

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

rgommers
Copy link
Member

Closes gh-190

@honno honno force-pushed the fix-complex-scalar-check branch from 3b4a954 to 88b64af Compare November 15, 2023 11:19
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!!

@honno honno merged commit 83f0bcd into data-apis:master Nov 15, 2023
@rgommers rgommers deleted the fix-complex-scalar-check branch November 15, 2023 11:58
@asmeurer
Copy link
Member

We'll need to check if this cleans up some of the xfails in the compat library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_square test failure with numpy complex64
3 participants