Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Extracted screens into constants #561

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Conversation

AtuyL
Copy link
Collaborator

@AtuyL AtuyL commented Oct 17, 2018

The screen-identifiers are strings. By extracting all existing identifiers into a constant-module we can now have code-suggestions in an IDE (ms vscode for example)

@martinheidegger martinheidegger changed the title added: "consts" dir. Extracted screens into constants Oct 18, 2018
Copy link
Collaborator

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful! thanks for the PR

@martinheidegger martinheidegger merged commit c8dde46 into react Oct 19, 2018
@martinheidegger martinheidegger deleted the add/screen_consts branch October 19, 2018 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants