Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPU executor #8399

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Remove GPU executor #8399

merged 1 commit into from
Dec 14, 2023

Conversation

hendrikmakait
Copy link
Member

Closes #8338 by removing the GPU executor. I am not aware of any usage of the GPU executor, so I'd recommend ripping it out instead of worrying about maintenance. I'm happy to reconsider if anybody brings an example of the executor being used to my attention.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       27 files  ±  0         27 suites  ±0   11h 51m 24s ⏱️ - 2m 59s
  3 937 tests  -   1    3 824 ✔️  -   2     110 💤 ±0    3 +1 
49 523 runs   - 13  47 221 ✔️  - 14  2 290 💤 ±0  12 +1 

For more details on these failures, see this check.

Results for commit 8e4c6d2. ± Comparison against base commit 5d9e406.

This pull request removes 1 test.
distributed.tests.test_worker ‑ test_gpu_executor

@hendrikmakait
Copy link
Member Author

cc @dask/gpu

@pentschev
Copy link
Member

No objections from me, I'm unaware of any uses of that in production code.

@jakirkham
Copy link
Member

Think this is something Matt added a while back ( #5084 ). There is some more context in issue ( #5084 ) in particular this comment ( #5084 (comment) )

IIUC it was meant as an experiment/proof-of-concept that would be followed up with other work. While there was related work (annotations), think that pivoted into HLGs, etc. So don't think the original idea went anywhere

If someone were to explore a GPU Executor today, probably a better answer would be add it to Dask-CUDA and make the minimal changes to Distributed (if any) to allow it to be plugged in. This might be a good approach to consider for other CUDA bits

All this to say ripping the GPU Executor out sounds like the right approach

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone for chiming in!

@fjetter fjetter merged commit 61edd73 into dask:main Dec 14, 2023
21 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling GPU diagnostics prevents GPU executor from getting created
4 participants