set [tool.setuptools] package-dir to force setuptools editables to append to sys.path #7804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Apr 26, 2023
| @@ -62,6 +62,7 @@ dask-worker = "distributed.cli.dask_worker:main" | |||
| [tool.setuptools] | |||
| include-package-data = true | |||
| zip-safe = false | |||
| package-dir = {"" = "."} | |||
There was a problem hiding this comment.
this causes setuptools to go down the same codepath as is_compat_mode:
if set(self.package_dir) == {""} and has_simple_layout or is_compat_mode:
# src-layout(ish) is relatively safe for a simple pth file
src_dir = self.package_dir.get("", ".")
|
I'm OK with this fix for now. @graingert offline we discussed briefly why the repo is not detected as simple. Can you summarize this here briefly for prosperity in case this hack fails us? |
|
@fjetter ah it's no good, this breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7782
pre-commit run --all-files