Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable worker dashboard by default in tests #4942

Closed

Conversation

gjoseph92
Copy link
Collaborator

Messages like

  /home/runner/work/distributed/distributed/distributed/node.py:160: UserWarning: Port 8787 is already in use.
  Perhaps you already have a cluster running?
  Hosting the HTTP server on port 36717 instead

take a a lot of lines in CI. Running the worker dashboard during tests seems unnecessary?

  • Passes black distributed / flake8 distributed / isort distributed

Messages like
```
  /home/runner/work/distributed/distributed/distributed/node.py:160: UserWarning: Port 8787 is already in use.
  Perhaps you already have a cluster running?
  Hosting the HTTP server on port 36717 instead
```
take a a _lot_ of lines in CI. Running the worker dashboard during tests seems unnecessary?
@fjetter
Copy link
Member

fjetter commented Jun 22, 2021

This is not connected to worker dashboads since worker dashboards use random ports. See #4806 and
#4928 for a fix (hopefully)

Also, even with dashboard=False we are actually starting an HTTP server. There is currently no way to not start an HTTP server

@gjoseph92
Copy link
Collaborator Author

Thanks, yes this is not actually the problem.

@gjoseph92 gjoseph92 closed this Jun 22, 2021
@gjoseph92 gjoseph92 deleted the gen_cluster/no-worker-dashboard branch June 22, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants