Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update space_saving.pyx #22

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Update space_saving.pyx #22

merged 1 commit into from
Aug 27, 2020

Conversation

TomAugspurger
Copy link
Member

  /Users/taugspurger/Envs/dask-dev/lib/python3.7/site-packages/crick/__init__.py:4: DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. Use `object` by
itself, which is identical in behavior, to silence this warning. If you specifically wanted the numpy scalar type, use `np.object_` here.
    from .space_saving import SpaceSaving

np.object is a deprecated alias for object in NumPy 1.20

`np.object` is an alias for `object`.
@jcrist
Copy link
Member

jcrist commented Jul 20, 2020

Thanks Tom! I haven't touched this code in forever, didn't know it was still being used anywhere. Out of curiousity, where was this being used that led you to find this?

@TomAugspurger
Copy link
Member Author

TomAugspurger commented Jul 20, 2020

It's used via dask's CI :) Would you prefer to just deprecate using crick?

https://github.com/dask/dask/blob/56d0d1be849cba4f7ea58ae47bfa76a594dc6c9b/continuous_integration/environment-3.8-dev.yaml#L34

@jcrist jcrist merged commit 1ef0e11 into dask:master Aug 27, 2020
@jcrist
Copy link
Member

jcrist commented Aug 27, 2020

Apologies for the delay here, this slipped through the cracks. The code still works, I'd forgotten that we ever got around to using it in dask. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants