feat: support descriptor wallets for RPC protx updateregistar #6066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
RPC
protx updateregistar
uses forcely LegacyScriptPubKeyMan instead using CWallet's interface.It causes a failures such as
What was done?
New method
SignSpecialTxPayloadByHash
is implemented in interface instead exporting raw private key for some address.See https://github.com/dashpay/dash-issues/issues/59 to track progress
How Has This Been Tested?
Functional test
feature_dip3_deterministicmns.py
to run by both ways - legacy and descriptor wallets.Run unit and functional tests.
Extra test done locally:
to flip flag descriptor wallets/legacy wallets for all functional tests.
Breaking Changes
N/A
Checklist: