Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: merge bitcoin-core/gui#180, #203, #179, #219, #214, #166, #296, #194, #280, #325, partial bitcoin-core/gui#79 (qt backports) #6049

Merged
merged 12 commits into from
Jun 10, 2024
Merged

backport: merge bitcoin-core/gui#180, #203, #179, #219, #214, #166, #296, #194, #280, #325, partial bitcoin-core/gui#79 (qt backports) #6049

merged 12 commits into from
Jun 10, 2024

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Jun 9, 2024 •
edited
Loading

Additional Information

develop (d7413ff) This PR
image image

Breaking Changes

None expected, changes are limited to refactoring, cleanup and refinement.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

kwvg added 12 commits June 9, 2024 17:33
@kwvg
merge bitcoin-core/gui#180: connection type follow-ups
582c6ec
@kwvg
merge bitcoin-core/gui#203: Display plain "Inbound" in peer details
57597df
@kwvg
merge bitcoin-core/gui#179: Add Type column to peers window, update p…
afd0648 
…eer details name/tooltip
@kwvg
qt: introduce GUIUtil::fixedPitchFont
722bd8d
@kwvg
partial bitcoin-core/gui#79: Embed monospaced font
7774bdb 
includes:
- 89e4219
- 623de12
@kwvg
merge bitcoin-core/gui#219: Prevent the main window popup menu
dc9b25e
@kwvg
merge bitcoin-core/gui#214: Disable requests context menu actions whe…
5a67b52 
…n appropriate
@kwvg
merge bitcoin-core/gui#166: Use enum type as switch argument in *Tabl…
c33afea 
…eModel
@kwvg
merge bitcoin-core/gui#296: Do not use QObject::tr plural syntax for …
504f834 
…numbers with a unit symbol
@kwvg
merge bitcoin-core/gui#194: Save/restore RPCConsole geometry only for…
a3ac694 
… window
@kwvg
merge bitcoin-core/gui#280: Remove user input from URI error message
09a8fc1
@kwvg
merge bitcoin-core/gui#325: Align numbers in the "Peer Id" column to …
ddca614 
…the right
@kwvg kwvg requested review from knst, UdjinM6 and PastaPastaPasta June 10, 2024 08:02
@kwvg kwvg added this to the 21 milestone Jun 10, 2024
@kwvg kwvg marked this pull request as ready for review June 10, 2024 08:02
UdjinM6
UdjinM6 approved these changes Jun 10, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, light ACK

PastaPastaPasta
PastaPastaPasta approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ddca614

@PastaPastaPasta PastaPastaPasta merged commit 8f2a460 into dashpay:develop Jun 10, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21
Development

Successfully merging this pull request may close these issues.
3 participants
@kwvg @UdjinM6 @PastaPastaPasta